单一职责原则重构

Question

我有一些代码想要重构，以使其不违反单一职责原则 (SRP)。

我知道以下 class 可能会因多种原因而改变：

分析的业务规则可能会改变
元数据架构可能会改变
上传方法可能会改变

但是，我很难弄清楚如何重构为单独的 classes。

Engine.java

package com.example;

import java.util.List;

public interface Engine {
  public List<Recording> analyze(List<String> files);
  public List<Recording> getMetadata(List<Recording> recordings);
  public List<Recording> upload(List<Recording> recordings);
}

通话Engine.java

package com.example;

import java.util.ArrayList;
import java.util.List;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class CallEngine implements Engine {

  final static Logger log = LoggerFactory.getLogger(Main.class);

  public List<Recording> analyze(List<String> files) {
    log.info("Analyzing recording files per business rules...");

    List<Recording> recordings = new ArrayList<Recording>();
    return recordings;
  }

  public List<Recording> getMetadata(List<Recording> r) {
    log.info("Retrieving metadata for calls...");
    List<Recording> recordings = new ArrayList<Recording>();
    return recordings;
  }

  public List<Recording> upload(List<Recording> r) {
    log.info("Uploading calls...");
    List<Recording> recordings = new ArrayList<Recording>();
    return recordings;
  }
}

Answer 1

public interface Analyzer {
  public void analyze();
}
public interface Retriever {
  public void retrieveMetadata();
}
public interface Uploader {
  public void upload();
}

public class EngineAnalyzer implements Analyzer {

  final static Logger log = LoggerFactory.getLogger(Main.class);

  public List<Recording> recordings;

  EngineAnaylzer(List<String> Files) {

  }

  public void analyze() {
    log.info("Analyzing recording files per business rules...");
  }  

}

Answer 2

SRP 主要是通过抽象接口背后的代码并将不相关功能的责任委派给运行时间接口背后的任何实现来实现的。

在这种情况下，您需要将职责抽象到它们自己的接口后面。

例如...

public interface Analyzer {
    public List<Recording> analyze(List<String> files);
}
public interface Retriever {
    public List<Recording> getMetadata(List<Recording> recordings);
}
public interface Uploader {
    public List<Recording> upload(List<Recording> r);
}

并将它们作为 Engine 实现的可注入依赖项。

public class CallEngine implements Engine {
    private Analyzer analyzer;
    private Retriever retriever;
    private Uploader uploader;

    public CallEngine(Analyzer analyzer, Retriever retriever, Uploader uploader) {
        this.analyzer = analyzer;
        this.retriever = retriever;
        this.uploader = uploader;        
    }

    public List<Recording> analyze(List<String> files) {
        return analyzer.analyze(files);
    }

    public List<Recording> getMetadata(List<Recording> r) {
        return retriever.getMetadata(r);
    }

    public List<Recording> upload(List<Recording> r) {
        return uploader.upload(r);
    }
}

他们的运行时间实现可以在不影响相关 class 实现的整体责任的情况下更改，这使得它更能适应变化。

单一职责原则重构

Single Responsibility Principle Refactor

java

interface

class

single-responsibility-principle

solid-principles