如何重构 case..when in Ruby

Question

  def readable
    uptime = (Time.now - self).to_i
    case uptime
    when 0 then 'just now'
    when 1 then 'uptime second ago'
    when 2..59 then uptime.to_s + ' seconds ago'
    when 60..119 then 'uptime minute ago' # 120 = 2 minutes
    when 120..3540 then (uptime / 60).to_i.to_s + ' minutes ago'
    when 3541..7100 then 'an hour ago' # 3600 = 1 hour
    when 7101..82_800 then ((uptime + 99) / 3600).to_i.to_s + ' hours ago'
    when 82_801..172_000 then 'uptime day ago' # 86400 = 1 day
    else ((uptime + 800) / 86_400).to_i.to_s + ' days ago'
    end
  end

Linter 提到以下错误，如何解决？

FeatureEnvy：Time#readable 比自己更多地引用 'uptime'（也许将其移至另一个 class？）[https://github.com/troessner/reek/blob/master/docs/Feature-Envy.md]
TooManyStatements：Time#readable 有大约 10 个语句 [https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md]
可读的分配分支条件大小太大高的。 [20.64/15]
可读性的圈复杂度太高。 [9/6]
方法行数过多。 [12/10]

Answer 1

看看 time_ago_in_words 并随意使用它或它的代码。

关于代码指标 - 您的代码非常简单，您应该只提取 uptime 方法。

如何重构 case..when in Ruby

How to refactor case..when in Ruby

ruby

refactoring

reek

rubocop