RSpec 会话控制器 - 用户在没有设计的情况下使用无效参数

Question

我有一个简单的消息应用程序可以学习 RSpec 一个用户可以在其中创建消息给另一个用户（只有登录的用户才能写消息）。我没用过devise和FactoryBot，这个app尽量简单，只是为了rspec学习

我想运行对会话控制器进行这些测试，但是第二个（当用户具有无效参数时）给了我一个错误 Expected response to be a <3XX: redirect>, but was a <200: OK> 并且我几个小时后不明白为什么。

RSpec.describe SessionsController, type: :controller do
  let(:create_user) { @user = User.create(username: 'John', password: 'test123') }

  describe 'POST #create' do

    context 'when user is logged in' do
      it 'loads correct user details and redirect to the root path' do
        create_user
        post :create, params: { session: { username: @user.username, password: @user.password } }
        expect(response).to redirect_to(root_path)
      end
    end

    context 'when user has invalid params' do
      before do
        create_user
        post :create, params: { session: { username: @user.username, password: 'somepass' } }
      end

      it 'render new action' do
        expect(assigns(:user)).not_to eq create_user
        expect(response).to redirect_to(action: 'new')
      end
    end
  end
end

会话控制器

class SessionsController < ApplicationController
  before_action :logged_in_redirect, only: %i[new create]

  def new; end

  def create
    user = User.find_by(username: params[:session][:username])
    if user && user.authenticate(params[:session][:password])
      session[:user_id] = user.id
      flash[:success] = 'You have successfully logged in'
      redirect_to root_path
    else
      flash.now[:error] = 'There was something wrong with your login'
      render 'new'
    end
  end
end

我不太确定第 expect(assigns(:user)).not_to eq create_user 行是否符合惯例，但这对结果无关紧要。

Answer 1

在您的测试中，您期望重定向响应：

expect(response).to redirect_to(action: 'new')

然后在控制器中您只渲染 new 模板：

render 'new'

我认为这是一种很好的渲染方法new，你应该改变你的规范来期待这一点。

expect(response).to render_template(:new)

RSpec 会话控制器 - 用户在没有设计的情况下使用无效参数

RSpec sessions controllers - user with invalid params without devise

ruby

rspec

ruby-on-rails

rspec-rails