table 驱动测试中的种族检测

Question

我有一个 table 驱动的测试和 init var(worker) 在 table 循环之外。我运行使用 go test -raсe 进行测试并添加 t.Parallel() 并且未检测到竞争条件。我可以假设我的测试没有 race condition:

//This mock could be in a separate file.
type mockWorker struct {
}
// implment our Worker iterface
func(md mockWorker)Work()error{
    return nil
}
type mockDoer struct{
    Error  error 
    Worker worker
}
// implment our Doer iterface
func(md mockDoer)Do()error{
    if err := md.Worker.Work(); err != nil {
        return err
    }
    return md.Error 
}

func TestBusinessDoer(t *testing.T){
    t.Parallel()
    worker := mockWorker{}
    cases := []struct{
        Name string
        ExpectError bool 
        Error error
    }{
        {
            Name:"test does business logic",
            ExpectError : false,
            Error : nil,
        },
        {
            Name:"test fails when dependency errors",
            ExpectError : true,
            Error : errors.New("an error"),
        },
    }

    for _,td := range cases{
        t.Run(td.Name, func (t *testing.T){
            doer := mockDoer{Error: td.Error, Worker: worker}
            err := mything.BusinessDoer(doer) 
            if td.ExpectError && err == nil{
                t.Fatalf("expected an error but got none")
            } 
            if ! td.ExpectError && err != nil{
                t.Fatalf("did not expect an error but got one %s ", err.Error())
            }
        })
    }
}

Answer 1

我认为您需要运行并行进行子测试。

你能在子测试中调用 t.Parallel() 并检查吗？

td := td
t.Run(td.Name, func (t *testing.T){
            t.Parallel()
            doer := mockDoer{Error: td.Error, Worker: worker}
            err := mything.BusinessDoer(doer) 
            if td.ExpectError && err == nil{
                t.Fatalf("expected an error but got none")
            } 
            if ! td.ExpectError && err != nil{
                t.Fatalf("did not expect an error but got one %s ", err.Error())
            }
        })

一些参考链接使其平行： https://gist.github.com/posener/92a55c4cd441fc5e5e85f27bca008721
https://rakyll.org/parallelize-test-tables/

table 驱动测试中的种族检测

Race detection in table driven test

concurrency

unit-testing

go

race-condition