为什么在此应用程序中会发生两次按钮点击?

Why do button clicks happen twice in this app?

我有一个应用程序,其中一个功能是您可以通过单击卡片视图来选择星期几。

我目前的问题是,如果您执行以下序列,您会得到意想不到的结果:

Clear -> pick day -> add task -> submit -> back button to Main Activity

当你执行这个序列时,数据库在初始清除后意外地再次被清除,或者如果你去一天,添加一个任务,然后导航回来,它再次运行 and/or 让你回到你刚离开那天的景色。

我注意到的和我尝试过的:

我的 foreach 循环做了它应该做的事情:翻阅工作日,直到它命中正确的一天......但它又做了一次?我从日志和完成后再次弹出 Toast 知道它发生了太多(它说 db cleared automatically followed by there's nothing to clear).我还尝试在 foreach 循环中添加断点,但我认为这对我没有帮助,因为如果我没记错的话,它只会中断循环的迭代一次?

我已经尝试了一个 activity 级别的布尔变量来让它在我需要的时候停止和启动,但问题最终是我要么需要按任何给定的卡片两次,但它不起作用选择第一个项目后,什么都不做,否则问题仍然存在。

我在 xml 中使用 onClick 作为按钮侦听器,但我也尝试将它编程到 activity kotlin class 中,但它没有差异

也许我只是在某处缺少额外的循环迭代,或者在适当的地方中断?

主要ActivityXML

<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".MainActivity" >

    <TextView
        android:id="@+id/top_box"
        android:layout_width="0dp"
        android:layout_height="90dp"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintTop_toTopOf="parent"/>

    <com.google.android.material.card.MaterialCardView
        android:id="@+id/clear_card"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:layout_margin="10dp"
        android:onClick="buttonClick"
        app:layout_constraintTop_toBottomOf="@id/top_box"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toLeftOf="@id/sunday_card"
        app:layout_constraintBottom_toTopOf="@id/wednesday_card">

        <TextView
            android:id="@+id/clear_card_text"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="20sp"
            android:gravity="center"
            />

    </com.google.android.material.card.MaterialCardView>

    <com.google.android.material.card.MaterialCardView
        android:id="@+id/sunday_card"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:layout_margin="10dp"
        android:onClick="buttonClick"
        app:layout_constraintTop_toBottomOf="@+id/top_box"
        app:layout_constraintLeft_toRightOf="@id/clear_card"
        app:layout_constraintRight_toLeftOf="@id/monday_card"
        app:layout_constraintBottom_toTopOf="@id/thursday_card">

        <TextView
            android:id="@+id/sunday_card_text"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="20sp"
            android:gravity="center"/>

    </com.google.android.material.card.MaterialCardView>

    <com.google.android.material.card.MaterialCardView
        android:id="@+id/monday_card"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:layout_margin="10dp"
        android:onClick="buttonClick"
        app:layout_constraintTop_toBottomOf="@id/top_box"
        app:layout_constraintLeft_toRightOf="@id/sunday_card"
        app:layout_constraintRight_toLeftOf="@id/tuesday_card"
        app:layout_constraintBottom_toTopOf="@id/friday_card">

        <TextView
            android:id="@+id/monday_card_text"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="20sp"
            android:gravity="center"/>

    </com.google.android.material.card.MaterialCardView>

    <com.google.android.material.card.MaterialCardView
        android:id="@+id/tuesday_card"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:layout_margin="10dp"
        android:onClick="buttonClick"
        app:layout_constraintTop_toBottomOf="@id/top_box"
        app:layout_constraintLeft_toRightOf="@id/monday_card"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintBottom_toTopOf="@id/saturday_card">

        <TextView
            android:id="@+id/tuesday_card_text"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="20sp"
            android:gravity="center"/>

    </com.google.android.material.card.MaterialCardView>

    <com.google.android.material.card.MaterialCardView
        android:id="@+id/wednesday_card"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:layout_margin="10dp"
        android:onClick="buttonClick"
        app:layout_constraintTop_toBottomOf="@id/clear_card"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toLeftOf="@id/thursday_card"
        app:layout_constraintBottom_toTopOf="@id/bottom_box">

        <TextView
            android:id="@+id/wednesday_card_text"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="20sp"
            android:gravity="center"/>

    </com.google.android.material.card.MaterialCardView>

    <com.google.android.material.card.MaterialCardView
        android:id="@+id/thursday_card"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:layout_margin="10dp"
        android:onClick="buttonClick"
        app:layout_constraintTop_toBottomOf="@id/sunday_card"
        app:layout_constraintLeft_toRightOf="@id/wednesday_card"
        app:layout_constraintRight_toRightOf="@id/friday_card"
        app:layout_constraintBottom_toTopOf="@id/bottom_box">

        <TextView
            android:id="@+id/thursday_card_text"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="20sp"
            android:gravity="center"/>

    </com.google.android.material.card.MaterialCardView>

    <com.google.android.material.card.MaterialCardView
        android:id="@+id/friday_card"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:layout_margin="10dp"
        android:onClick="buttonClick"
        app:layout_constraintTop_toBottomOf="@id/monday_card"
        app:layout_constraintLeft_toRightOf="@id/thursday_card"
        app:layout_constraintRight_toLeftOf="@id/saturday_card"
        app:layout_constraintBottom_toTopOf="@id/bottom_box">

        <TextView
            android:id="@+id/friday_card_text"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="20sp"
            android:gravity="center"/>

    </com.google.android.material.card.MaterialCardView>

    <com.google.android.material.card.MaterialCardView
        android:id="@+id/saturday_card"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:layout_margin="10dp"
        android:onClick="buttonClick"
        app:layout_constraintTop_toBottomOf="@id/tuesday_card"
        app:layout_constraintLeft_toRightOf="@id/friday_card"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintBottom_toTopOf="@id/bottom_box">

        <TextView
            android:id="@+id/saturday_card_text"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:textSize="20sp"
            android:gravity="center"/>

    </com.google.android.material.card.MaterialCardView>

    <TextView
        android:id="@+id/bottom_box"
        android:layout_width="0dp"
        android:layout_height="90dp"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintBottom_toBottomOf="parent"/>

</androidx.constraintlayout.widget.ConstraintLayout>

主要Activity

class MainActivity : AppCompatActivity() {
    private lateinit var binding: ActivityMainBinding
    private val plannerViewModel: PlannerViewModel by viewModels {
        PlannerViewModelFactory((application as PlannerApplication).repository)
    }

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        binding = ActivityMainBinding.inflate(layoutInflater)
        setContentView(binding.root)

        val clearButtonText = binding.clearCardText
        val sundayButtonText = binding.sundayCardText
        val mondayButtonText = binding.mondayCardText
        val tuesdayButtonText = binding.tuesdayCardText
        val wednesdayButtonText = binding.wednesdayCardText
        val thursdayButtonText = binding.thursdayCardText
        val fridayButtonText = binding.fridayCardText
        val saturdayButtonText = binding.saturdayCardText

        // Setting day card names
        clearButtonText.text = "Clear"
        sundayButtonText.text = "Sun"
        mondayButtonText.text = "Mon"
        tuesdayButtonText.text = "Tue"
        wednesdayButtonText.text = "Wed"
        thursdayButtonText.text = "Thu"
        fridayButtonText.text = "Fri"
        saturdayButtonText.text = "Sat"
        sundayButtonText.text = "Sun"
    }

    private fun startWeekdayActivity(day: Weekday) {
        val intent = Intent(this, WeekdayActivity::class.java)
        intent.putExtra("dayId", day.id)
        this.startActivity(intent)
    }

    private fun clearDb() {
        val alertDialog: AlertDialog? = this?.let { outerIt ->
            val builder = AlertDialog.Builder(outerIt)
            builder.apply {
                setPositiveButton("Clear",
                        DialogInterface.OnClickListener { dialog, id ->

                            plannerViewModel.allTasks.observe(outerIt, {
                                if (it.count() == 0) {
                                    Toast.makeText(context, "No tasks to clear", Toast.LENGTH_SHORT).show()
                                }
                                else {
                                    plannerViewModel.deleteAllTasks()
                                    Toast.makeText(context, "Tasks cleared", Toast.LENGTH_SHORT).show()
                                }
                            })
                            })
                setNegativeButton("Cancel",
                        DialogInterface.OnClickListener { dialog, id ->
                            // User cancelled the dialog
                        })
            }
                    .setTitle("Clear tasks?")
                    .setMessage("Are you sure you want to clear the weeks tasks?")

            // Create the AlertDialog
            builder.create()
        }

                alertDialog?.show()
    }

    private fun checkDay(dayIn: String) {
        var dayOut: Weekday? = null
        plannerViewModel.allWeekdays.observe(this, { weekdays ->
            weekdays?.let {
                weekdays.forEach {
                        if (dayIn == "clear_card" && it.day == "Clear") {
                                clearDb()
                                dayOut = it
                        }
                    else {
                        val dayInAbr = dayIn.substring(0, 3).toLowerCase(Locale.ROOT)
                        val dayOutAbr = it.day.substring(0,3).toLowerCase(Locale.ROOT)

                        if (dayInAbr == dayOutAbr) {
                            dayOut = it
                            dayOut?.let { startWeekdayActivity(it) }
                        }
                    }

                    if (dayOut != null) {
                        return@let
                    }
                }
            }
        })
    }

    fun buttonClick(view: View) {
        when(view.id) {
            R.id.clear_card -> checkDay(view.context.resources.getResourceEntryName(R.id.clear_card).toString())
            R.id.sunday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.sunday_card).toString())
            R.id.monday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.monday_card).toString())
            R.id.tuesday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.tuesday_card).toString())
            R.id.wednesday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.wednesday_card).toString())
            R.id.thursday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.thursday_card).toString())
            R.id.friday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.friday_card).toString())
            R.id.saturday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.saturday_card).toString())
        }
    }
}

Jay在评论中回答的问题

如果您知道我如何将 SO 积分和声誉归功于他们,请告诉我!

我需要停止每次 checkDay() 运行 调用更多的观察者实例。将观察员移动到 onCreate() 以便他们只 运行 一次似乎解决了我的问题!

主要工作代码Activity

class MainActivity : AppCompatActivity() {
    private lateinit var binding: ActivityMainBinding
    private val plannerViewModel: PlannerViewModel by viewModels {
        PlannerViewModelFactory((application as PlannerApplication).repository)
    }

    lateinit var weekdayList: List<Weekday>
    lateinit var taskList: List<Task>

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        binding = ActivityMainBinding.inflate(layoutInflater)
        setContentView(binding.root)

        val clearButtonText = binding.clearCardText
        val sundayButtonText = binding.sundayCardText
        val mondayButtonText = binding.mondayCardText
        val tuesdayButtonText = binding.tuesdayCardText
        val wednesdayButtonText = binding.wednesdayCardText
        val thursdayButtonText = binding.thursdayCardText
        val fridayButtonText = binding.fridayCardText
        val saturdayButtonText = binding.saturdayCardText

        // Setting day card names
        clearButtonText.text = "Clear"
        sundayButtonText.text = "Sun"
        mondayButtonText.text = "Mon"
        tuesdayButtonText.text = "Tue"
        wednesdayButtonText.text = "Wed"
        thursdayButtonText.text = "Thu"
        fridayButtonText.text = "Fri"
        saturdayButtonText.text = "Sat"
        sundayButtonText.text = "Sun"

        plannerViewModel.allTasks.observe(this, {
            taskList = it
        })

        plannerViewModel.allWeekdays.observe(this, {
            weekdayList = it
        })
    }

    private fun startWeekdayActivity(day: Weekday) {
        val intent = Intent(this, WeekdayActivity::class.java)
        intent.putExtra("dayId", day.id)
        this.startActivity(intent)
    }

    private fun clearDb(taskList: List<Task>) {
        val alertDialog: AlertDialog? = this?.let { outerIt ->
            val builder = AlertDialog.Builder(outerIt)
            builder.apply {
                setPositiveButton("Clear",
                        DialogInterface.OnClickListener { dialog, id ->
                            if (taskList.count() == 0) {
                                Toast.makeText(context, "No tasks to clear", Toast.LENGTH_SHORT).show()
                            } else {
                                plannerViewModel.deleteAllTasks()
                                Toast.makeText(context, "Tasks cleared", Toast.LENGTH_SHORT).show()
                            }
                        })
                setNegativeButton("Cancel",
                        DialogInterface.OnClickListener { dialog, id ->
                            // User cancelled the dialog
                        })
            }
                    .setTitle("Clear tasks?")
                    .setMessage("Are you sure you want to clear the weeks tasks?")

            builder.create()
        }

        alertDialog?.show()
    }

    private fun checkDay(dayIn: String, weekdayList: List<Weekday>) {
        weekdayList.forEach {
            if (dayIn == "clear_card" && it.day == "Clear") {
                clearDb(taskList)
            } else {
                val dayInAbr = dayIn.substring(0, 3).toLowerCase(Locale.ROOT)
                val dayOutAbr = it.day.substring(0, 3).toLowerCase(Locale.ROOT)

                if (dayInAbr == dayOutAbr) {
                    startWeekdayActivity(it)
                }
            }
        }
    }

    fun buttonClick(view: View) {
        when (view.id) {
            R.id.clear_card -> checkDay(view.context.resources.getResourceEntryName(R.id.clear_card).toString(), weekdayList)
            R.id.sunday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.sunday_card).toString(), weekdayList)
            R.id.monday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.monday_card).toString(), weekdayList)
            R.id.tuesday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.tuesday_card).toString(), weekdayList)
            R.id.wednesday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.wednesday_card).toString(), weekdayList)
            R.id.thursday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.thursday_card).toString(), weekdayList)
            R.id.friday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.friday_card).toString(), weekdayList)
            R.id.saturday_card -> checkDay(view.context.resources.getResourceEntryName(R.id.saturday_card).toString(), weekdayList)
        }
    }
}