我怎样才能使这个递归函数更有效率？

Question

我创建此函数是为了从 FTP 服务器递归复制整个目录。它工作得很好，除了它比使用 FileZilla 执行相同的操作慢大约 4 倍。下载 FileZilla 中的目录大约需要 55 秒，但使用此功能需要 229 秒。我该怎么做才能让它 download/run 更快？

Private Sub CopyEntireDirectory(ByVal directory As String)
    Dim localPath = localDirectory & formatPath(directory)
    'creates directory in destination path
    IO.Directory.CreateDirectory(localPath)

    'Gets the directory details so I can separate folders from files
    Dim fileList As ArrayList = Ftp.ListDirectoryDetails(directory, "")

    For Each item In fileList
        'checks if it's a folder or file: d=folder
        If (item.ToString().StartsWith("d")) Then
            'gets the directory from the details
            Dim subDirectory As String = item.ToString().Substring(item.ToString().LastIndexOf(" ") + 1)
            CopyEntireDirectory(directory & "/" & subDirectory)
        Else
            Dim remoteFilePath As String = directory & "/" & item.ToString().Substring(item.ToString().LastIndexOf(" ") + 1)
            Dim destinationPath = localPath & "\" & item.ToString().Substring(item.ToString().LastIndexOf(" ") + 1)
            'downloads file to destination directory
            Ftp.DownLoadFile(remoteFilePath, destinationPath)
        End If
    Next
End Sub

下面是一直占用的下载功能

Public Sub DownLoadFile(ByVal fromFilename As String, ByVal toFilename As String)
    Dim files As ArrayList = Me.ListDirectory(fromFilename, "")
    Dim request As FtpWebRequest = Me.CreateRequestObject(fromFilename)
    request.Method = WebRequestMethods.Ftp.DownloadFile

    Dim response As FtpWebResponse = CType(request.GetResponse(), FtpWebResponse)
    If response.StatusCode <> FtpStatusCode.OpeningData AndAlso response.StatusCode <> FtpStatusCode.DataAlreadyOpen Then
        Throw New ApplicationException(Me.BuildCustomFtpErrorMessage(request, response))
    End If

    Dim fromFilenameStream As Stream = response.GetResponseStream()
    Dim toFilenameStream As FileStream = File.Create(toFilename)

    Dim buffer(BLOCK_SIZE) As Byte
    Dim bytesRead As Integer = fromFilenameStream.Read(buffer, 0, buffer.Length)
    Do While bytesRead > 0
        toFilenameStream.Write(buffer, 0, bytesRead)
        Array.Clear(buffer, 0, buffer.Length)
        bytesRead = fromFilenameStream.Read(buffer, 0, buffer.Length)
    Loop

    response.Close()
    fromFilenameStream.Close()
    toFilenameStream.Close()
End Sub

Answer 1

缓慢显然是在 FTP 命令中。运行您的其他代码可能会以递归方式每秒运行一百万次，因为它没有任何意义。

FTP 下载（无论它是什么）应该能够定义块的大小是抓取。这将是您速度的关键。它需要根据您的连接速度和文件大小进行优化。没有适合每个人的正确号码。

编辑

根据新代码，问题出在您的 BLOCK_SIZE 中，我认为这是一个常量。玩这个尺寸以获得最佳速度。

提示：这应该是 1024 的倍数

我怎样才能使这个递归函数更有效率？

How can I make this recursive function more efficient?

vb.net

recursion

performance

ftp-client