重构模型方法 multiple mount_uploader for carrierwave

Question

我有 Rails (4) 应用程序，我正在使用 carrierwave 将图像上传到生产中的 S3 存储桶（和开发中的本地存储桶）。一切正常，但我想重构我的代码。

我的模型：

class Blogging < ActiveRecord::Base

mount_uploader :picture1, Picture1Uploader  
mount_uploader :picture2, Picture1Uploader  
mount_uploader :picture3, Picture1Uploader    
mount_uploader :picture4, Picture1Uploader  
mount_uploader :picture5, Picture1Uploader  
mount_uploader :picture6, Picture1Uploader  
mount_uploader :picture7, Picture1Uploader  
mount_uploader :picture8, Picture1Uploader  
mount_uploader :picture9, Picture1Uploader  
mount_uploader :picture10, Picture1Uploader  
mount_uploader :picture11, Picture1Uploader  
validate :picture_size  


private
  def picture_size
    if picture1.size > 5.megabytes
        errors.add(:picture1, "should be less than 5 MB")
    end
  end


end

经过一些重构，我有这个：

class Blogging < ActiveRecord::Base


for i in 1..11 
 mount_uploader :"picture#{i}", Picture1Uploader
end


validate :picture_size
validates :picture1, :news_title, :news_body, presence: true 



private

 def picture_size
    pics = Array.new(11) {|i| "picture#{i+1}"} 
        pics.each do |p|
        if p.size > 5.megabytes
        errors.add(:picture1, "should be less than 5 MB")
        end
     end
 end
end

mount_uploader，虽然丑但做工精。但是我找不到办法让picture_size限制每张图片的大小（从1到11）。

我可以使用 11 次不同的方法或使用 case 运算符使其工作。但我正在尝试重构。
我很想将我的 "for" 循环放在一个方法中并调用它，但不知道如何调用。如果我定义一个方法并调用它所有图像消失并且没有文件上传（本地或 S3 存储桶）

Answer 1

试试这个：

def picture_size
  pics = Array.new(11) {|i| "picture#{i+1}"}.each do |pic_name|
    p = self.send pic_name
    if p.size > 5.megabytes
      self.errors.add(:picture1, "should be less than 5 MB")
    end
  end
end

重构模型方法 multiple mount_uploader for carrierwave

refactor model method multiple mount_uploader for carrierwave

refactoring

model

ruby-on-rails

carrierwave