我的人生游戏逻辑有问题吗？

Question

我在 JavaScript 中编写了 Conway 的生命游戏，它似乎正在向屏幕生成某些内容，但它似乎并没有遵循相同的逻辑或运行康威的人生游戏。我不知道哪里出了问题，为什么它是运行这样的，我的代码在我看来应该遵循正确的规则。谁能发现为什么运行不正确？这是一个 link 到 JSFiddle https://jsfiddle.net/nw4Lw7z9/1/

 //object constructor
function cell(){
    this.alive = Math.random() >0.8;    
    this.neighbours = 0;  //number of live neighbours
    this.checkneighbours = [[-1,-1],[-1,0],[0,-1],[-1,1],[1,-1],[1,0],[0,1],[1,1]];
}


function GoL(size){
    this.size = size;
    this.grid = this.makeGrid(size);
};      

    GoL.prototype.makeGrid = function(size){
        var grid = [];
        for(var i=0; i<size; i++){
            var row=[];
            for(var j =0; j<size; j++){
                row.push(new cell());   
            }
            grid.push(row);
        }
            return grid;
    };  

    GoL.prototype.drawGrid = function(){
        grid.innerHTML = '';
        for(var i=0;i<this.size;i++){
            var row =this.grid[i];
            var rowCell="";
            for(var j=0;j<this.size;j++){
                var cell = row[j];
                if(cell.alive){
                    rowCell += "X|";
                }else{
                    rowCell += " |";
                }               
            }
            grid.innerHTML = grid.innerHTML + rowCell + "\n";
        }       
    };  

GoL.prototype.underpopulation = function(ro,col){
    var cell = this.grid[ro][col];
    if(cell.neighbours <2){
        return true;
    }else{
        return false;   
    }
};  
GoL.prototype.overpopulation = function(ro,col){
    var cell = this.grid[ro][col];
    if(cell.neighbours >3){
        return true;
    }else{
        return false;   
    }
};  

GoL.prototype.backtolife = function(ro,col){
    var cell = this.grid[ro][col];
    if(cell.neighbours ==3 && !cell.alive){
    return true;
    }else{
        return false;   
    }   
};


GoL.prototype.update = function(ro,col){    
    var cell = this.grid[ro][col];
   // cell.num_of_neighbours = 0;
    for(var i =0; i<cell.checkneighbours.length; i++){
        var checkneighbour = cell.checkneighbours[i];
        var neighbour1 = checkneighbour[0];
        var neighbour2 = checkneighbour[1];
        if(neighbour1>=0 && neighbour1 < this.size && neighbour2 >=0 && neighbour2 < this.size){
        var currentneighbour = this.grid[ro + neighbour1][col+neighbour2];
        if(currentneighbour.alive){
            cell.neighbours++;
        }
       }
    }
};

GoL.prototype.updateAll = function(){
    for(var i=0; i<this.size-1;i++){
        for(var j=0; j<this.size-1;j++){
            this.update(i,j);
        }
    }   
}

GoL.prototype.cellstatus = function(ro,col){
    var cell = this.grid[ro][col];
    if(this.underpopulation(ro,col) || this.overpopulation(ro,col)){
        cell.alive = false;
    }else if(this.backtolife(ro,col)){
        cell.alive = true;
    }
};

GoL.prototype.allcellstatus = function(ro,col){
    for(var i=0; i<this.size;i++){
        for(var j=0; j<this.size;j++){
            this.cellstatus(i,j);
        }
    }   
};


var gameoflife = new GoL(100);   

var interval = setInterval(function(){
    gameoflife.drawGrid();
    gameoflife.updateAll();
    gameoflife.allcellstatus();
},500);

HTML

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <title>Game of Life</title>
    <script src="cell.js" type="text/javascript"> </script>
  </head>
  <body>
    <pre id="grid">
    </pre>
  </body>
</html>

Answer 1

您的 update 函数很难理解。我已经清理干净了。试一试：

GoL.prototype.update = function(ro,col){    
    var cell = this.grid[ro][col];
    // Uncomment this. Need to re-set every iteration (and fix typo)
    cell.neighbours = 0;
    for(var i = 0; i < cell.checkneighbours.length; i++){
        // Get new indices
        var newRow = ro + cell.checkneighbours[i][0];
        var newCol = col + cell.checkneighbours[i][1];

        // Check that indices are in range
        if (newRow >= 0 && newRow < this.grid.length && newCol >= 0 && newCol < this.grid[newRow].length) {
            if(this.grid[newRow][newCol].alive){
                cell.neighbours++;
            }
        }
    }
};

我的人生游戏逻辑有问题吗？

issue with my game of life logic?

javascript

html

logic

game-physics

conways-game-of-life