使用 php 更新数据库中的正确行时出现问题

Question

我正在尝试为在我的电台播放的艺术家创建一个投票系统。我使用的源代码来自：http://dl.howcode.org/download/97ff383c7d4dc9939c65c9e6fab2a5dc

我发现的问题是，无论选择了哪个选项，投票都会使用数据库中第一行的数字进行更新，因此，例如，如果第一行有 3 票并且用户尝试投票有 0 票的人，它将把正确艺术家的票数从 1 票改为 4 票...我希望这有意义吗？

我的密码是：

[编辑] 我已将查询更改为 fetch assoc 以使其更易于理解。

<?php

    $voteID = $_GET['voteID'];
    $connect = mysqli_connect('xxx', 'xxx', 'xxx', 'xxx');
    $query = "SELECT * FROM listenervotes WHERE voteID='$voteID'" ;
    $q = mysqli_query($connect, $query);
    while($row = mysqli_fetch_assoc($q)){
        $id = $row["id"];
        $voteTitle = $row["voteTitle"];
        $voteID = $row["voteID"];
        $ipaddress = $row["ipAddress"];
        echo "<h3>$voteTitle</h3>";
        ?>
        <table>
            <form action="" method="POST">
        <?php
            $artists = "SELECT * FROM artists WHERE voteID='$voteID'" ;
            $q2 = mysqli_query($connect, $artists);
            while($r = mysqli_fetch_assoc($q2)){
                $artist = $r["artistName"];
                $votes = $r["votes"];
                $genre = $r["genre"];
                $ip = $_SERVER['REMOTE_ADDR'];
                $newIpAddress = $ipaddress."$ip, ";
                $newVotes = $votes + 1;
                if (isset($_POST['vote'])) {
                    $voteOption = $_POST['voteOption'];
                    if ($voteOption == ""){
                        die("You haven't selected anyone!");
                    }else{

                        $ipaddressE = explode(",", $ipaddress);
                        if(in_array($ip, $ipaddressE)){
                            die("You have already voted!");
                        }else{
                            mysqli_query($connect, "UPDATE artists SET votes='$newVotes' WHERE voteID='$voteID' AND artistName='$voteOption'");
                            mysqli_query($connect, "UPDATE listenervotes SET ipaddress='$newIpAddress' WHERE voteID='$voteID'");
                            die('You voted successfully!<br><tr><td>'.$artist.'</td><td>'.$genre.'</td><td>'.$votes.' Votes</td></tr>');
                        }
                    }
                }
                echo '<tr><td>'.$artist.'</td><td>'.$genre.'</td><td><input type="radio" name="voteOption" value="'.$artist.'"</td></tr>';
            }

    }
?>

我可能遗漏了一些明显的东西，在我看来，我在想我需要在设置新值之前以某种方式遍历行，如果是这样，如何以及在哪里？

Answer 1

您似乎总是遍历所有行并使用找到的第一个值更新相关行。添加对 ID 的检查应该做：

<?php

$voteID = $_GET['voteID'];
$connect = mysqli_connect('xxx', 'xxx', 'xxx', 'xxx');
$query = "SELECT * FROM listenervotes WHERE voteID='$voteID'" ;
$q = mysqli_query($connect, $query);
while($row = mysqli_fetch_assoc($q)){
    $id = $row["id"];
    $voteTitle = $row["voteTitle"];
    $voteID = $row["voteID"];
    $ipaddress = $row["ipAddress"];
    echo "<h3>$voteTitle</h3>";
    ?>
    <table>
        <form action="" method="POST">
    <?php
        $artists = "SELECT * FROM artists WHERE voteID='$voteID'" ;
        $q2 = mysqli_query($connect, $artists);
        while($r = mysqli_fetch_assoc($q2)){
            $artist = $r["artistName"];
            $votes = $r["votes"];
            $genre = $r["genre"];
            $ip = $_SERVER['REMOTE_ADDR'];
            $newIpAddress = $ipaddress."$ip, ";
            $newVotes = $votes + 1;
            if (isset($_POST['vote'])) {
                $voteOption = $_POST['voteOption'];
                if ($voteOption == ""){
                    die("You haven't selected anyone!");
                }else{

                    $ipaddressE = explode(",", $ipaddress);
                    if(in_array($ip, $ipaddressE)){
                        die("You have already voted!");
                    }elseif ($voteOption === $artist) { // Don't run UPDATE when we're on the wrong row.
                        mysqli_query($connect, "UPDATE artists SET votes='$newVotes' WHERE voteID='$voteID' AND artistName='$voteOption'");
                        mysqli_query($connect, "UPDATE listenervotes SET ipaddress='$newIpAddress' WHERE voteID='$voteID'");
                        die('You voted successfully!<br><tr><td>'.$artist.'</td><td>'.$genre.'</td><td>'.$votes.' Votes</td></tr>');
                    }
                }
            }
            echo '<tr><td>'.$artist.'</td><td>'.$genre.'</td><td><input type="radio" name="voteOption" value="'.$artist.'"</td></tr>';
        }

}

?>

使用 php 更新数据库中的正确行时出现问题

Problems updating correct row in databse with php

php

mysql

mysqli

row