Spring 启动 1.4.3 和@ControllerAdvice
Spring Boot 1.4.3 and @ControllerAdvice
我有一个 spring 4 应用程序,它的 ControllerAdvice 扩展了 ResponseEntityExceptionHandler,在异常出现时工作正常。
@ControllerAdvice
@Slf4j
public class ExceptionManager extends ResponseEntityExceptionHandler {
@Override
protected ResponseEntity<Object> handleMethodArgumentNotValid(MethodArgumentNotValidException ex,
HttpHeaders headers,
HttpStatus status,
WebRequest request) {
final ValidationErrors errors = getErrors(ex.getBindingResult());
headers.setContentType(MediaType.APPLICATION_JSON);
return handleExceptionInternal(ex, errors, headers, HttpStatus.BAD_REQUEST, request);
}
@Override
protected ResponseEntity<Object> handleBindException(BindException ex, HttpHeaders headers, HttpStatus status, WebRequest request) {
final ValidationErrors errors = getErrors(ex.getBindingResult());
headers.setContentType(MediaType.APPLICATION_JSON);
return handleExceptionInternal(ex, errors, headers, HttpStatus.BAD_REQUEST, request);
}
@ExceptionHandler(ValidationException.class)
public ResponseEntity handleValidationException(ValidationException ex) {
log.warn("Validation error", ex);
return ex.toResponseEntity();
}
@ExceptionHandler(HttpClientErrorException.class)
public ResponseEntity handleHttpClientErrorException(HttpClientErrorException ex) {
log.error(ex.getMessage());
return new ResponseEntity(ex.getResponseBodyAsString(), ex.getStatusCode());
}
@ExceptionHandler({Exception.class, RuntimeException.class})
protected ResponseEntity<Object> handleRootException(Exception ex, WebRequest request) {
return handleException(request, ex);
}
...
}
然而,在解组器异常的情况下,例如
Exception received:
org.springframework.http.converter.HttpMessageNotReadableException: Could not unmarshal to [class com.company.etc.v1.PojoResponse]: null; nested exception is javax.xml.bind.UnmarshalException
- with linked exception:
[org.xml.sax.SAXParseException; lineNumber: 5; columnNumber: 28; Attribute name "entResponse" associated with an element type "assetDocum" must be followed by the ' = ' character.]
at org.springframework.http.converter.xml.Jaxb2RootElementHttpMessageConverter.readFromSource(Jaxb2RootElementHttpMessageConverter.java:149)
at org.springframework.http.converter.xml.AbstractXmlHttpMessageConverter.readInternal(AbstractXmlHttpMessageConverter.java:61)
at org.springframework.http.converter.AbstractHttpMessageConverter.read(AbstractHttpMessageConverter.java:193)
at org.springframework.web.client.HttpMessageConverterExtractor.extractData(HttpMessageConverterExtractor.java:104)
at org.springframework.web.client.RestTemplate$ResponseEntityResponseExtractor.extractData(RestTemplate.java:917)
at org.springframework.web.client.RestTemplate$ResponseEntityResponseExtractor.extractData(RestTemplate.java:901)
at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:655)
at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:613)
at org.springframework.web.client.RestTemplate.exchange(RestTemplate.java:531)
at com.company.service.impl.SearchAsset.searchAssets(SearchAsset.java:42)
... 57 common frames omitted
Caused by: javax.xml.bind.UnmarshalException: null
at javax.xml.bind.helpers.AbstractUnmarshallerImpl.createUnmarshalException(AbstractUnmarshallerImpl.java:335)
at com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.createUnmarshalException(UnmarshallerImpl.java:563)
at com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0(UnmarshallerImpl.java:249)
at com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java:214)
at javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:140)
at javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:123)
at org.springframework.http.converter.xml.Jaxb2RootElementHttpMessageConverter.readFromSource(Jaxb2RootElementHttpMessageConverter.java:133)
... 127 common frames omitted
Caused by: org.xml.sax.SAXParseException: Attribute name "entResponse" associated with an element type "assetDocum" must be followed by the ' = ' character.
at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:177)
... 131 common frames omitted
没有捕获异常!
它发生在特定情况下,当 @RestController 使用调用外部端点的服务时。在我的例子中,外部服务 returns 和 XML,如果它被破坏(如上面的异常),那么 SAXParseException
不会被捕获并自动转换为 400 Bad Request spring 为空 body。它也根本没有记录。
如果在我的 RestController 中添加一个方法 @ExceptionHandler(Throwable.class)
,这个方法会被调用并且我可以控制发回的错误。
这正常吗?我在想 ControllerAdvice 可以集中所有的异常处理,不需要在每个控制器中都有 ExceptionHandler。
刚刚找到解决方案:删除 extends ResponseEntityExceptionHandler
。如果你 @ControllerAdvice
不扩展任何东西,看起来效果会更好。
我有一个 spring 4 应用程序,它的 ControllerAdvice 扩展了 ResponseEntityExceptionHandler,在异常出现时工作正常。
@ControllerAdvice
@Slf4j
public class ExceptionManager extends ResponseEntityExceptionHandler {
@Override
protected ResponseEntity<Object> handleMethodArgumentNotValid(MethodArgumentNotValidException ex,
HttpHeaders headers,
HttpStatus status,
WebRequest request) {
final ValidationErrors errors = getErrors(ex.getBindingResult());
headers.setContentType(MediaType.APPLICATION_JSON);
return handleExceptionInternal(ex, errors, headers, HttpStatus.BAD_REQUEST, request);
}
@Override
protected ResponseEntity<Object> handleBindException(BindException ex, HttpHeaders headers, HttpStatus status, WebRequest request) {
final ValidationErrors errors = getErrors(ex.getBindingResult());
headers.setContentType(MediaType.APPLICATION_JSON);
return handleExceptionInternal(ex, errors, headers, HttpStatus.BAD_REQUEST, request);
}
@ExceptionHandler(ValidationException.class)
public ResponseEntity handleValidationException(ValidationException ex) {
log.warn("Validation error", ex);
return ex.toResponseEntity();
}
@ExceptionHandler(HttpClientErrorException.class)
public ResponseEntity handleHttpClientErrorException(HttpClientErrorException ex) {
log.error(ex.getMessage());
return new ResponseEntity(ex.getResponseBodyAsString(), ex.getStatusCode());
}
@ExceptionHandler({Exception.class, RuntimeException.class})
protected ResponseEntity<Object> handleRootException(Exception ex, WebRequest request) {
return handleException(request, ex);
}
...
}
然而,在解组器异常的情况下,例如
Exception received:
org.springframework.http.converter.HttpMessageNotReadableException: Could not unmarshal to [class com.company.etc.v1.PojoResponse]: null; nested exception is javax.xml.bind.UnmarshalException
- with linked exception:
[org.xml.sax.SAXParseException; lineNumber: 5; columnNumber: 28; Attribute name "entResponse" associated with an element type "assetDocum" must be followed by the ' = ' character.]
at org.springframework.http.converter.xml.Jaxb2RootElementHttpMessageConverter.readFromSource(Jaxb2RootElementHttpMessageConverter.java:149)
at org.springframework.http.converter.xml.AbstractXmlHttpMessageConverter.readInternal(AbstractXmlHttpMessageConverter.java:61)
at org.springframework.http.converter.AbstractHttpMessageConverter.read(AbstractHttpMessageConverter.java:193)
at org.springframework.web.client.HttpMessageConverterExtractor.extractData(HttpMessageConverterExtractor.java:104)
at org.springframework.web.client.RestTemplate$ResponseEntityResponseExtractor.extractData(RestTemplate.java:917)
at org.springframework.web.client.RestTemplate$ResponseEntityResponseExtractor.extractData(RestTemplate.java:901)
at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:655)
at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:613)
at org.springframework.web.client.RestTemplate.exchange(RestTemplate.java:531)
at com.company.service.impl.SearchAsset.searchAssets(SearchAsset.java:42)
... 57 common frames omitted
Caused by: javax.xml.bind.UnmarshalException: null
at javax.xml.bind.helpers.AbstractUnmarshallerImpl.createUnmarshalException(AbstractUnmarshallerImpl.java:335)
at com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.createUnmarshalException(UnmarshallerImpl.java:563)
at com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0(UnmarshallerImpl.java:249)
at com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java:214)
at javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:140)
at javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:123)
at org.springframework.http.converter.xml.Jaxb2RootElementHttpMessageConverter.readFromSource(Jaxb2RootElementHttpMessageConverter.java:133)
... 127 common frames omitted
Caused by: org.xml.sax.SAXParseException: Attribute name "entResponse" associated with an element type "assetDocum" must be followed by the ' = ' character.
at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:177)
... 131 common frames omitted
没有捕获异常!
它发生在特定情况下,当 @RestController 使用调用外部端点的服务时。在我的例子中,外部服务 returns 和 XML,如果它被破坏(如上面的异常),那么 SAXParseException
不会被捕获并自动转换为 400 Bad Request spring 为空 body。它也根本没有记录。
如果在我的 RestController 中添加一个方法 @ExceptionHandler(Throwable.class)
,这个方法会被调用并且我可以控制发回的错误。
这正常吗?我在想 ControllerAdvice 可以集中所有的异常处理,不需要在每个控制器中都有 ExceptionHandler。
刚刚找到解决方案:删除 extends ResponseEntityExceptionHandler
。如果你 @ControllerAdvice
不扩展任何东西,看起来效果会更好。