有时我会因为 Time.now 而得到失败的香料，不明白为什么

Question

所以我在模型中有一个方法

class << self
  def last_week
    start = Time.zone.now.beginning_of_week - 7.days
    finish = start + 7.days
    where('appointment_at >= ? AND appointment_at < ?', start, finish).order(appointment_at: :desc)
  end
end

我为这个方法编写规范。

RSpec.describe Appointment, type: :model, vcr: { record: :none } do
  let!(:time) { Time.now }
  let(:appointment_at) { time }

  context '.last_week' do
    let!(:scoped_appointment) { create(:appointment, appointment_at: time - 2.days) }
    let!(:another_appointment) { create(:appointment, appointment_at: time - 16.days) }

    it do
      travel_to(time) do
        expect(Appointment.last_week).to include(scoped_appointment)
        expect(Appointment.last_week).not_to include(another_appointment)
      end
    end
  end
 end

有时我会因错误而未能通过此规范。

expected #<ActiveRecord::Relation []> to include #<Appointment id: 18, lead_id: 27, body: nil, appointment_at: "2019-02-25 00:59:47", google_id: nil, ... "pending", user_id: 22, notify: nil, cc_emails: nil, appointment_minutes: nil, status_message: nil>
   Diff:
   @@ -1,2 +1,2 @@
   -[#<Appointment id: 18, lead_id: 27, body: nil, appointment_at: "2019-02-25 00:59:47", google_id: nil, created_at: "2019-02-27 00:59:47", updated_at: "2019-02-27 00:59:47", timezone: nil, subject: "Meeting with Lead", address: nil, notification: nil, status: "pending", user_id: 22, notify: nil, cc_emails: nil, appointment_minutes: nil, status_message: nil>]
   +[]

我不明白为什么？

而且我有一个建议，我应该严格设置 time

在 spec_helper.rb

$now = DateTime.parse('2020-01-01 00:00:01 -0500')

会不会对？为什么？

Answer 1

您的测试设置很脆弱。它会根据您运行您的规范在一周中的哪一天中断。

您模型中的范围 returns 上周周一到周日的预约（您正在调用 beginning_of_week 并向其添加 7 天）

因此，如果您的测试运行在星期三进行，就像您提供的示例中那样，约会的 appointment_at 字段将设置为星期一（因为您将其计算为 Time.now - 2.days ).这意味着您的范围将不包括该约会。

我建议您在设置中使用特定时间。鉴于您当前的设置，使用 let(:time) { DateTime.parse('2019-02-25 00:00:00') } 应该有效

有时我会因为 Time.now 而得到失败的香料，不明白为什么

and sometimes I get failed spices because of Time.now, can't understand why

ruby-on-rails

rspec

rspec-rails

rspec3