如果设置 STYLE_NO_TITLE,带有 AppCompatDialog 的 DialogFragment 会崩溃
DialogFragment with AppCompatDialog crashes if STYLE_NO_TITLE is set
我正在尝试在 AppCompat v22.1 中使用带有片段的新 material 主题对话框。 According to Chris Banes,要做到这一点:
Just return new AppCompatDialog(getActivity(), getTheme())
from
onCreateDialog(Bundle)
.
正在设置:
public class MyFragment extends DialogFragment
{
public MyFragment() { }
public Dialog onCreateDialog(Bundle savedInstanceState) {
return new AppCompatDialog(getActivity(), getTheme());
}
...
}
正常情况下完美运行;该对话框的主题和一切都正确。但是,当我们尝试显示带有 STYLE_NO_TITLE
选项的对话框时:
MyFragment fragment = new MyFragment();
fragment.setStyle(DialogFragment.STYLE_NO_TITLE, 0);
fragment.show(getSupportFragmentManager(), "DIALOG");
它导致以下异常和崩溃:
05-19 12:18:38.806 15458-15458/? E/AndroidRuntime﹕ FATAL EXCEPTION: main
Process: com.example.test.testdialog, PID: 15458
android.util.AndroidRuntimeException: requestFeature() must be called before adding content
at com.android.internal.policy.impl.PhoneWindow.requestFeature(PhoneWindow.java:302)
at android.app.Dialog.requestWindowFeature(Dialog.java:1066)
at android.support.v4.app.DialogFragment.getLayoutInflater(DialogFragment.java:317)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:955)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1138)
at android.support.v4.app.BackStackRecord.run(BackStackRecord.java:740)
at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1501)
at android.support.v4.app.FragmentManagerImpl.run(FragmentManager.java:458)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5254)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
我猜问题可能与 DialogFragment
调用 requestWindowFeature()
而不是 supportRequestWindowFeature()
(?)
有关
这个问题有什么解决方法吗?
根据 Blackbelt link 的问题,我们应该 return AppCompatDialog 并使用 supportRequestWindowFeature()。我建议这样更改:
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
AppCompatDialog dialog = new AppCompatDialog(getActivity(), getTheme());
return dialog;
}
@Override
public void setupDialog(Dialog dialog, int style) {
switch (style) {
case STYLE_NO_INPUT:
dialog.getWindow().addFlags(
WindowManager.LayoutParams.FLAG_NOT_FOCUSABLE |
WindowManager.LayoutParams.FLAG_NOT_TOUCHABLE);
// fall through...
case STYLE_NO_FRAME:
case STYLE_NO_TITLE:
((AppCompatDialog) dialog).supportRequestWindowFeature(Window.FEATURE_NO_TITLE);
}
}
或更好,尽量不要触摸原始代码:
@Override
public void setupDialog(Dialog dialog, int style) {
super.setupDialog(dialog,style);
if(style == STYLE_NO_TITLE)
((AppCompatDialog) dialog).supportRequestWindowFeature(Window.FEATURE_NO_TITLE);
}
这是 fixed in v22.1.1.
AppCompat v22.1 中的错误
它在 v23 和 was fixed once more, in v23.0.1 中再次崩溃。
在撰写本文时它工作正常。
我正在尝试在 AppCompat v22.1 中使用带有片段的新 material 主题对话框。 According to Chris Banes,要做到这一点:
Just return
new AppCompatDialog(getActivity(), getTheme())
fromonCreateDialog(Bundle)
.
正在设置:
public class MyFragment extends DialogFragment
{
public MyFragment() { }
public Dialog onCreateDialog(Bundle savedInstanceState) {
return new AppCompatDialog(getActivity(), getTheme());
}
...
}
正常情况下完美运行;该对话框的主题和一切都正确。但是,当我们尝试显示带有 STYLE_NO_TITLE
选项的对话框时:
MyFragment fragment = new MyFragment();
fragment.setStyle(DialogFragment.STYLE_NO_TITLE, 0);
fragment.show(getSupportFragmentManager(), "DIALOG");
它导致以下异常和崩溃:
05-19 12:18:38.806 15458-15458/? E/AndroidRuntime﹕ FATAL EXCEPTION: main
Process: com.example.test.testdialog, PID: 15458
android.util.AndroidRuntimeException: requestFeature() must be called before adding content
at com.android.internal.policy.impl.PhoneWindow.requestFeature(PhoneWindow.java:302)
at android.app.Dialog.requestWindowFeature(Dialog.java:1066)
at android.support.v4.app.DialogFragment.getLayoutInflater(DialogFragment.java:317)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:955)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1138)
at android.support.v4.app.BackStackRecord.run(BackStackRecord.java:740)
at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1501)
at android.support.v4.app.FragmentManagerImpl.run(FragmentManager.java:458)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5254)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
我猜问题可能与 DialogFragment
调用 requestWindowFeature()
而不是 supportRequestWindowFeature()
(?)
这个问题有什么解决方法吗?
根据 Blackbelt link 的问题,我们应该 return AppCompatDialog 并使用 supportRequestWindowFeature()。我建议这样更改:
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
AppCompatDialog dialog = new AppCompatDialog(getActivity(), getTheme());
return dialog;
}
@Override
public void setupDialog(Dialog dialog, int style) {
switch (style) {
case STYLE_NO_INPUT:
dialog.getWindow().addFlags(
WindowManager.LayoutParams.FLAG_NOT_FOCUSABLE |
WindowManager.LayoutParams.FLAG_NOT_TOUCHABLE);
// fall through...
case STYLE_NO_FRAME:
case STYLE_NO_TITLE:
((AppCompatDialog) dialog).supportRequestWindowFeature(Window.FEATURE_NO_TITLE);
}
}
或更好,尽量不要触摸原始代码:
@Override
public void setupDialog(Dialog dialog, int style) {
super.setupDialog(dialog,style);
if(style == STYLE_NO_TITLE)
((AppCompatDialog) dialog).supportRequestWindowFeature(Window.FEATURE_NO_TITLE);
}
这是 fixed in v22.1.1.
AppCompat v22.1 中的错误它在 v23 和 was fixed once more, in v23.0.1 中再次崩溃。
在撰写本文时它工作正常。