受保护的单元测试失败

Question

我有一个 class EllaService，我想在那里测试 EllaService::isTrafficIgnored 方法。代码如下，

@Service
public class EllaService {


    @Autowired
    @Qualifier( ELLA_CONNECTOR_BEAN_NAME )
    private EntityServiceConnectable<EllaResponseDto> connector;

    @Autowired
    @Getter
    private EllaFilterConfigHolder configHolder;

    @Autowired
    @Getter
    private EllaConfiguration config;

    @Autowired
    private Environment env;


    protected boolean isTrafficIgnored( IrisBo irisBo ) {

        if( config.isExternalCostumerFilter( this.env ) && irisBo.getBuyer().isExternalKnownCustomer() ) {
            return true;
        }

        if( config.isInternalCostumerFilter( this.env ) && irisBo.getBuyer().isInternalKnownCustomer() ) {
            return true;
        }

        return checkIfShopIdFilterIsApplied( irisBo );
    }

    // ========================================================================

    private boolean checkIfShopIdFilterIsApplied( IrisBo irisBo ) {
        return configHolder.getShopIdsToFilterSet().contains( irisBo.getOrder().getShopId() );
    }

    // ........................

}

我为测试class、

中的方法提供了2个测试

@RunWith( PowerMockRunner.class )
@PrepareForTest( EllaDtoConverter.class )
public class EllaServiceTest {

    private static final String VALID_TRX_ID = "valid-trx-id";
    private static final String VALID_GW_ID = "valid-gw-id";

    @InjectMocks
    private EllaService ellaService;

    private IrisBo validIrisBo;

    @Mock
    private EllaRequestDto ellaRequestDto;

    @Mock
    private EntityServiceConnectable<EllaResponseDto> entityServiceConnector;

    @Mock
    private EllaResponseDto ellaResponseDto;

    @Mock
    private EllaConfiguration ellaConfiguration;

    @Mock
    private EllaFilterConfigHolder ellaFilterConfigHolder;

    @Mock
    private EllaService ellaServiceMock;

    @Mock
    private Environment environment;

    @SuppressWarnings( "unchecked" )
    @Before
    public void setup() {

        PowerMockito.mockStatic( EllaDtoConverter.class );
        when( EllaDtoConverter.convertToRequest( any() ) ).thenReturn( ellaRequestDto );

        ServiceResponse<EllaResponseDto> validServiceResponseMock = mock( ServiceResponse.class );
        when( entityServiceConnector.call( any(), (HttpHeaders) any() ) ).thenReturn( validServiceResponseMock );

        when( validServiceResponseMock.isSuccess() ).thenReturn( true );
        when( validServiceResponseMock.getResponse() ).thenReturn( ellaResponseDto );
        when( validServiceResponseMock.getErrorMessage() ).thenReturn( "" );

        when( ellaServiceMock.getConfigHolder() ).thenReturn( ellaFilterConfigHolder );
        when( ellaServiceMock.getConfig() ).thenReturn( ellaConfiguration );
        when( ellaConfiguration.isExternalCostumerFilter( any() ) ).thenReturn( false );
        when( ellaConfiguration.isInternalCostumerFilter( any() ) ).thenReturn( false );
        when( ellaConfiguration.extractShopIdsToFilter( any() ) ).thenReturn( "" );

        when( ellaFilterConfigHolder.getShopIdsToFilterSet() ).thenReturn( new HashSet<>() );

        validIrisBo = new IrisBo();

        RequestInformation requestInfo = Mockito.mock( RequestInformation.class );

        when( requestInfo.getTransactionId() ).thenReturn( VALID_TRX_ID );
        when( requestInfo.getGatewayRequestId() ).thenReturn( VALID_GW_ID );

        OrderBo orderBo = new OrderBo();

        orderBo.addProduct( INVOICE );
        orderBo.setShopId( 123 );

        AddressBo addressBo = new AddressBo();

        addressBo.setStreetName( "Rutherfordstraße" );
        addressBo.setHouseNumber( "2" );
        addressBo.setZipCode( "12489" );

        ServiceBo serviceBo = new ServiceBo();

        serviceBo.setDate( LocalDate.parse( "2018-11-26" ) );
        serviceBo.setExistingCustomer( Boolean.TRUE );

        TransactionBo transactionBo = new TransactionBo();

        transactionBo.setTrxId( "valid-trx-id" );
        transactionBo.setCurrencyCode( "EUR" );
        transactionBo.setAmount( 12.5 );

        BuyerBo buyerBo = new BuyerBo();

        buyerBo.setBillingAddress( addressBo );
        buyerBo.setDeliveryAddress( addressBo );

        validIrisBo.setRequestInfo( requestInfo );
        validIrisBo.setOrder( orderBo );
        validIrisBo.setBuyer( buyerBo );

        validIrisBo.getBuyer().setBillingAddress( addressBo );
        validIrisBo.getBuyer().setDeliveryAddress( addressBo );

        validIrisBo.setTrackingId( "9241999998422820706039" );
        validIrisBo.setEmail( "test@ratepay.com" );
        validIrisBo.setIp( "123.120.12.12" );
        validIrisBo.setFirstName( "Max" );
        validIrisBo.setLastName( "Musterman" );
    }



    @Test
    public void testIsTrafficIgnoredWhenExternalCostumerFilterReturnsTrueAndBuyerIsExternalKnownCustomer() {

        when( ellaConfiguration.isExternalCostumerFilter( environment ) ).thenReturn( true );
        validIrisBo.getBuyer().setExternalKnownCustomer( true );

        assertEquals( true, ellaService.isTrafficIgnored( validIrisBo ) );
    }

    @Test
    public void testIsTrafficIgnoredWhenInternalCostumerFilterReturnsTrueAndBuyerIsInternalKnownCustomer() {

        when( ellaConfiguration.isInternalCostumerFilter( environment ) ).thenReturn( true );
        validIrisBo.getBuyer().setInternalKnownCustomer( true );

        assertEquals( true, ellaService.isTrafficIgnored( validIrisBo ) );
    }


}

现在，我想测试一下

一个。如果条件

if( config.isExternalCostumerFilter( this.env ) && irisBo.getBuyer().isExternalKnownCustomer() )

为假

b。条件

if( config.isInternalCostumerFilter( this.env ) && irisBo.getBuyer().isInternalKnownCustomer() )

是false

c。

checkIfShopIdFilterIsApplied( irisBo )

returns true

那么isTrafficIgnored也会returntrue。

我的测试方法如下，

@Test
    public void testIsTrafficIgnoredWhenAllOtherConditionsAreFalseButCheckIfShopIdFilterIsAppliedReturnsTrue() throws Exception {

        when( ellaConfiguration.isExternalCostumerFilter( environment ) ).thenReturn( false );
        when( ellaConfiguration.isInternalCostumerFilter( environment ) ).thenReturn( false );

        PowerMockito.when( ellaServiceMock, "checkIfShopIdFilterIsApplied", validIrisBo ).thenReturn( true );

        assertTrue( ellaService.isTrafficIgnored( validIrisBo ) );
    }

我得到下面提供的 NullPointerException 异常，

java.lang.NullPointerException
    at com.ratepay.iris.ella.service.EllaService.checkIfShopIdFilterIsApplied(EllaService.java:118)

我更新了提供的测试方法，

    @Test
    public void testIsTrafficIgnoredWhenAllOtherConditionsAreFalseButCheckIfShopIdFilterIsAppliedReturnsTrue() throws Exception {

        EllaFilterConfigHolder e = spy( new EllaFilterConfigHolder() );

        doReturn( true ).when( e.getShopIdsToFilterSet().contains( validIrisBo.getOrder().getShopId() ) );

        when( ellaConfiguration.isExternalCostumerFilter( environment ) ).thenReturn( false );
        when( ellaConfiguration.isInternalCostumerFilter( environment ) ).thenReturn( false );

        PowerMockito.when( ellaServiceMock, "checkIfShopIdFilterIsApplied", validIrisBo ).thenReturn( true );

        assertTrue( ellaService.isTrafficIgnored( validIrisBo ) );
    }

我得到了提供的错误堆栈，

org.mockito.exceptions.misusing.UnfinishedStubbingException: 
Unfinished stubbing detected here:
-> at com.ratepay.iris.ella.service.EllaServiceTest.testIsTrafficIgnoredWhenAllOtherConditionsAreFalseButCheckIfShopIdFilterIsAppliedReturnsTrue(EllaServiceTest.java:216)

E.g. thenReturn() may be missing.
Examples of correct stubbing:
    when(mock.isOk()).thenReturn(true);
    when(mock.isOk()).thenThrow(exception);
    doThrow(exception).when(mock).someVoidMethod();
Hints:
 1. missing thenReturn()
 2. you are trying to stub a final method, which is not supported
 3: you are stubbing the behaviour of another mock inside before 'thenReturn' instruction if completed


    at com.ratepay.iris.ella.service.EllaServiceTest.testIsTrafficIgnoredWhenAllOtherConditionsAreFalseButCheckIfShopIdFilterIsAppliedReturnsTrue(EllaServiceTest.java:216)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:326)
    at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:89)
    at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:97)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:310)

如何更正我的测试？

更新

感觉我的问题不清楚。我想知道如何将语句 checkIfShopIdFilterIsApplied( irisBo ) 模拟为 return true?

Answer 1

我成功编写了测试并在下面提供。

@Test
    public void testIsTrafficIgnoredWhenAllOtherConditionsAreFalseButCheckIfShopIdFilterIsAppliedReturnsTrue() throws Exception {

        when( ellaConfiguration.isExternalCostumerFilter( environment ) ).thenReturn( false );
        when( ellaConfiguration.isInternalCostumerFilter( environment ) ).thenReturn( false );

        Set<Integer> shopIdsForTheOrders = new HashSet<>();

        shopIdsForTheOrders.add( 145 );
        shopIdsForTheOrders.add( 500 );
        shopIdsForTheOrders.add( SHOP_ID_FOR_ORDER );

        when( ellaFilterConfigHolder.getShopIdsToFilterSet() ).thenReturn( shopIdsForTheOrders );
        assertTrue( ellaService.isTrafficIgnored( validIrisBo ) );
    }

受保护的单元测试失败

Unit testing for a protected is failing

java

junit

mockito

powermock