关于简化功能的建议

Question

我有一个这样的实体 Contracts：

public partial class Contracts
{
    public Contracts()
    {
        ListKindWorks = new HashSet<ListKindWorks>();
        ListSubjects = new HashSet<ListSubjects>();
    }

    public int Id { get; set; }
    public string Num { get; set; }
    public DateTime DateConclusion { get; set; }
    public int Worker { get; set; }
    public DateTime DateStartWork { get; set; }
    public DateTime DateEndWork { get; set; }
    public float Salary { get; set; }

    public virtual Workers WorkerNavigation { get; set; }
    public virtual ICollection<ListKindWorks> ListKindWorks { get; set; }
    public virtual ICollection<ListSubjects> ListSubjects { get; set; }   
}

和函数ShowUpdateDialog():

/// <summary>
/// Open dialog for update chosen Contract
/// </summary>
/// <param name="c">chosen Contract</param>
internal void ShowUpdateDialog(Contracts c)
{
    Contract = c;
    using (ContractForm form = new ContractForm())
    {
        form.Fill(model.Data);
        form.Fill(Contract);
        form.Fill(model.GetUI(Mode.UPDATE));
        if (form.ShowDialog() == DialogResult.OK)
        {
            bool result = true;
            try
            {
                using (ModelContext context = new ModelContext())
                {
                    context.Attach(Contract);
                    Contract = form.GetMainValues(Contract);
                    Contract = form.GetDetailValues(Contract);
                    context.SaveChanges();
                }
            }
            catch (Exception ex)
            {
                result = false;
                string msg = string.Format("Ошибка во время обновления записи в базе данных. Детали: {0}", ex.Message);
                form.ShowError(msg);
            }

            if (result)
            {
                ContractUpdatedSuccessEvent?.Invoke(this, EventArgs.Empty);
            }
        }
    }
}

外部变量：

public Contracts Contract { get; set; }

它不是每次都分配内存，而是 public，以便在成功更新的情况下另一个 class 可以使用它并插入到 DataGridView 中。因此，我没有访问数据库以获取记录的当前值，因为数据来自 DataGridView。要跟踪更改，请使用 context.Attach(Contract).

internal Contracts GetMainValues(Contracts c)
{
    c.Num = tbNum.Text;
    c.Salary = float.Parse(tbSalary.Text);
    c.DateConclusion = dpDateConclusion.Value;
    c.DateStartWork = dpDateStart.Value;
    c.DateEndWork = dpDateEnd.Value;
    Item item = (Item)cbWorker.SelectedItem;
    c.Worker = item.Id;

    return c;
}


internal Contracts GetDetailValues(Contracts c)
{
    listKindWorks.Clear();
    listSelectedSubjects.Clear();

    foreach (int index in clbKindWork.CheckedIndices)
    {
        int id = ((Item)clbKindWork.Items[index]).Id;
        ListKindWorks item = new ListKindWorks
        {
            IdContract = c.Id,
            IdKindWork = id
        };
        listKindWorks.Add(item);
    }
    foreach (Item item in lbSelectedSubject.Items)
    {
        ListSubjects subject = new ListSubjects
        {
            IdContract = c.Id,
            IdSubject = item.Id
        };
        listSelectedSubjects.Add(subject);
    }

    c.ListKindWorks = listKindWorks;
    c.ListSubjects = listSelectedSubjects;

    return c;
}

我的问题如下：

当 if (.. == DialogResult.OK) 为真时，我需要将当前 Contract 更新为 form 的新值，如下所示：

context.Attach(Contract);
Contract = form.GetMainValues(Contract);
Contract = form.GetDetailValues(Contract);
context.SaveChanges();

但是因此这段代码必须变成using (ContractForm..)。否则无法从 form 获取新值。如果我创建一个像 Contracts 这样的新变量并像这样分离函数 Update：

private void Update(Contracts c)
{
    using (ModelContext context = new ModelContext())
    {
        context.Attach(Contract);
        Contract = c;
        context.SaveChanges();
    }
}

GetDetailValues() 中的值没有更新。为什么？

我可以简化这段代码吗？

更新：

根据答案 Henk Holterman 和我的代码 private void Update(Contracts c):

更改了 GetMainValues() 的值，但未更改 GetDetailValues()

的值

Answer 1

我添加到 Contracts 方法 Update() 并在 .Attach()

之后调用它

internal void Update(Contracts c)
{
    this.Num = c.Num;
    this.Salary = c.Salary;
    this.Worker = c.Worker;
    this.FullName = c.FullName;
    this.DateConclusion = c.DateConclusion;
    this.DateStartWork = c.DateStartWork;
    this.DateEndWork = c.DateEndWork;
    this.ListKindWorks = c.ListKindWorks;
    this.ListSubjects = c.ListSubjects;
}

private void Update(Contracts oldValue, Contracts newValue)
{
    using (ModelContext context = new ModelContext())
    {
        context.Attach(oldValue);
        oldValue.Update(newValue);
        // oldValue = newValue; // .Attach does not respond to this
        context.SaveChanges();
    }
}

关于简化功能的建议

The advice on the simplification of the functions

c#

entity-framework

crud

entity-framework-core