FtpWebRequest出错如何清理资源

Question

不知道这个FtpWebRequest是不是出错了，然后去了catch事件。我看到了一个示例代码，其中他们发布了我在 catch 事件中未注释的内容，以清理资源。

但我不知道在这种情况下正确的做法是什么？我应该把所有这些都放到：= null;或者这是错误的做法？正确的做法是什么？

cleanUp(sourceStream, ref response, ref requestStream, ref request);

void uploadimage()
        {
            String sourceimage = "C:/ESD/image_2.jpg";
            Task<bool> task = FtpUploadFile(sourceimage);
            if (task.IsFaulted == false)
            {
                MessageBox.Show(task.Result.ToString());
            }
        }
        private Task closeRequestStreamAsync(Stream requestStream) { return Task.Run(() => { requestStream.Close(); }); }
        public async Task<bool> FtpUploadFile(string filename)
        {
            //if exception occurs we want to be able to close these
            FtpWebResponse response = null;
            FtpWebRequest request = null;
            FileStream sourceStream = null;
            Stream requestStream = null;
            try
            {
                bool isimage = false; String ext = Path.GetExtension(filename);
                if (ext == ".jpg" || ext == ".jpeg" || ext == ".png" || ext == ".gif" || ext == ".bmp") { isimage = true; }

                request = (FtpWebRequest)WebRequest.Create("ftp://someurl.com/Folder1/test1.jpg");
                request.UsePassive = true;
                if (isimage == true) { request.UseBinary = true; } //for images
                if (isimage == false) { request.UseBinary = false; } //for text
                request.KeepAlive = true; //keep the connection open
                request.Method = WebRequestMethods.Ftp.UploadFile;
                request.ConnectionGroupName = "Group1";
                request.ServicePoint.ConnectionLimit = 4;

                //These are the credentials.
                request.Credentials = new NetworkCredential("username", "password");


                sourceStream = File.OpenRead(filename);
                byte[] buffer = new byte[sourceStream.Length];
                await sourceStream.ReadAsync(buffer, 0, buffer.Length);
                sourceStream.Close();

                requestStream = await request.GetRequestStreamAsync();
                await requestStream.WriteAsync(buffer, 0, buffer.Length);
                //MPM  This is the call that takes the time     
                await closeRequestStreamAsync(requestStream);

                //response = (FtpWebResponse)request.GetResponse();
                WebResponse responseWeb = await request.GetResponseAsync();
                response = (FtpWebResponse)responseWeb;
                if (response.StatusDescription.Contains("226"))
                {
                    //This means that we successfully have uploaded the file!
                }
                response.Close();
                return true;
            }
            catch (Exception ex)
            {
                string errMSG = string.Format("Upload File failed, exception: {0}", ex.Message);
        //cleanUp(sourceStream, ref response, ref requestStream, ref request);
                return false;
            }
        }

Answer 1

为确保即使发生异常也关闭 Web 请求、响应和流对象，应在 using 块中定义它们。

代码可以简化为：

var ext = Path.GetExtension(filename);
var imageExtensions=new[]{".jpg",".jpeg",".png",".gif",".bmp"};
var isimage = imageExtensions.Contains(ext);

var request = (FtpWebRequest)WebRequest.Create("ftp://someurl.com/Folder1/test1.jpg");

request.UseBinary =isimage;
request.Method = WebRequestMethods.Ftp.UploadFile;
request.ConnectionGroupName = "Group1";
request.ServicePoint.ConnectionLimit = 4;

//These are the credentials.
request.Credentials = new NetworkCredential("username", "password");

using(var sourceStream = File.OpenRead(filename))
using(var requestStream = await request.GetRequestStreamAsync())
{
    await sourceStream.CopyToAsync(requestStream);
}

using(var responseWeb = await request.GetResponseAsync())
{
    var response = (FtpWebResponse)responseWeb;
    if (response.StatusDescription.Contains("226"))
    {
         return true;
    }
}
.....

我删除了 KeepAlive and UsePassive 设置器，因为 true 是它们的默认值。

WebRequest 本身不持有任何资源，因此它不实现 IDisposable。调用 GetRequestStream() 时会建立与服务器的连接。需要 disposing/closing 的值是 sourceStream、requestStream 和 responseWeb.

FtpWebRequest出错如何清理资源

How to clean up resources if FtpWebRequest goes wrong

c#

ftpwebrequest