是否回滚此存储过程中的所有事务
Will all transaction in this stored procedure be rolled back
我在 SQL 服务器中创建了一个存储过程（如下所示）并尝试包含一个回滚事务，因为我需要一个 "stored procedure that has a transaction around it, so that if/when it fails all inserts will be rolled back."
我不确定这是否有效，或者是否会有效，我还不能测试，因为我只是在本地开发，但想知道是否有人不介意查看存储过程的回滚事务部分，并建议是否在正确的道路？
USE AutomatedTesting
GO
ALTER PROCEDURE [dbo].[spInsertTestCases]
(@AddedTFS INT,
@Scenario NVARCHAR(500),
@TargetTableName NVARCHAR(100),
@TargetFieldName NVARCHAR(100),
@ExpectedResult NVARCHAR(100),
@TargetTableDBName NVARCHAR(100),
@TargetTableSchema NVARCHAR(100),
@TargetFieldIsDateTime NVARCHAR(1),
@TestCaseIdentifiers dbo.TestCaseIdentifiers READONLY ) -- can only be READONLY. meaning you cannot amend the param
/* @TestCaseIdentifiers var will be prepopulated
TestDataIdentifiersNEW is a custom data type which has fields (TestSequence ColumnName ColumnValue IsAlphaNumeric)
so stored procedure is called like:
EXEC [dbo].[spTest_UserDefinedDatatype] 'param1','param2' @temp_testdata
@temp_testdata will already be defined and popualted(INSERT INTO ) before exec to add in 1 to many rows.
for example:
ColumnName ColumnValue
PATIENTID 123456
SOURCESYS PAS
in simple terms above EXEC is:
EXEC [dbo].[spTest_UserDefinedDatatype] 'param1','param2' 'PATIENTID 123456'
'SOURCESYS PAS'
*/
AS
BEGIN TRY
BEGIN TRANSACTION
BEGIN
--DECLARE @TableNameUpdate SYSNAME = @TargetTableName
--DECLARE @CDI SYSNAME = REPLACE(@TargetTableName,'CDO','CDI') -- so if targettablename param is CDO then swap it to CDI. why?
DECLARE @sql VARCHAR(MAX) = ' INSERT INTO [dbo].[TestCasesIdentifier] ([TestCaseId], [TestCaseSequence], [FieldName], [FieldValue], [AlphaNumeric]) VALUES '
DECLARE @i INT = 1
DECLARE @TableNameUpdate SYSNAME = @TargetTableName
DECLARE @CDI SYSNAME = REPLACE(@TargetTableName,'CDO','CDI')
DECLARE @ColName SYSNAME
DECLARE @Ret NVARCHAR(256)
DECLARE @sql2 NVARCHAR(MAX)
DECLARE @TestCaseID INT = -1 --does this need default variable?
DECLARE @ErrorCode INT = @@error
DECLARE @TestSequence INT
DECLARE @ColumnName VARCHAR(100)
DECLARE @ColumnValue VARCHAR(100)
DECLARE @IsAlphaNumeric BIT
DECLARE @TableTestSequence INT = ISNULL((SELECT MAX([TableTestSequence]) + 1 FROM TestCases WHERE @TargetTableName = [TargetTableName]), 1)
-- INSERT into TestCases. 1 record
-- An assumption that a number of fields will have defaults on them - if not, extra fields will need adding
INSERT INTO [dbo].[TestCases] ([AddedTFS], [TableTestSequence], [Scenario],
[TargetTableName], [TargetFieldName], [ExpectedResult],
[TargetTableDBName], [TargetTableSchema], [TargetFieldIsDateTime])
VALUES (@AddedTFS, -- AddedTFS (The TFS Number of the Development carried out)
ISNULL((SELECT MAX([TableTestSequence]) + 1 -- TableTestSequence (Generates the next Sequence Number for a Table)
FROM TestCases -- if table doesnt exist in TestCases then sets to 1
WHERE @TargetTableName = [TargetTableName]), 1),
@Scenario, -- Scenario (A description of the scenario use GIVEN and WHERE)
@TargetTableName, -- TargetTableName (References the Target Table entered at the top of this SQL - SET @TableName = 'CDO_APC_ELECTIVE_ADMISSION_LIST')
@TargetFieldName, -- TargetFieldName (The Field in which we want to test)
@ExpectedResult, -- ExpectedResult (The expected output/result of the field in which we want to test)
@TargetTableDBName, -- The DB to be used
@TargetTableSchema, -- the schema to be used
@TargetFieldIsDateTime) ---- 1 = Yes, 0 = No (Is Target field a datetime field)
-- Grab the identity value just generated by the last statement and the last error code generated
-- in order to reference TestCases PK when adding to TestCaseIdentifiers
SELECT @TestCaseID = SCOPE_IDENTITY(), @ErrorCode = @@error
IF @ErrorCode = 0 --OR @TestCaseID <> -1 -- @ErrorCode <> 0 if error then back out testcases INSERT? surely should use BEGIN/ROLLBACK tran
--IF @ErrorCode = 0 OR @TestCaseID <> -1
-- If there was no error creating the TestCase record, create the records for the WHERE clause
BEGIN
/*
rollback insert if no matching records
rollback insert if SQL returns more than 1 record
return error message to user
*/
SELECT
ic.index_column_id, c.name
INTO #tmp
FROM sys.indexes i
JOIN sys.index_columns ic ON i.object_id = ic.object_id
AND i.index_id = ic.index_id
JOIN sys.columns c ON c.column_id = ic.column_id
AND c.object_id = ic.object_id
JOIN sys.tables t ON c.object_id = t.object_id
WHERE t.name = @CDI
AND i.is_primary_key = 1
IF (SELECT COUNT(*) FROM @TestCaseIdentifiers) = 0
--IF @PKValues IS NULL
BEGIN
WHILE @i <= (SELECT COUNT(*) FROM #tmp)
BEGIN
SELECT @ColName = [name]
FROM #tmp
WHERE index_column_id = @i
-- if @expectedvalue IS NULL
SET @sql2 = 'SELECT TOP 1 @RetvalOut = ' + QUOTENAME(@ColName) + ' FROM ' + QUOTENAME(@CDI) + ' ORDER BY NEWID()'
-- else
-- SET @sql2 = ''
EXECUTE sp_executesql @command = @sql2, @ParmDefinition = N'@RetvalOut NVARCHAR(MAX) OUTPUT', @retvalOut = @Ret OUTPUT
SET @sql += '(' + CONVERT(VARCHAR(100),@TestCaseID) + ',' + CONVERT(VARCHAR(10),@i) + ',''' + @ColName + ''',''' + @Ret + ''',1),'
SET @i+=1
SELECT @sql = REVERSE(SUBSTRING(REVERSE(@sql),2,8000))
PRINT @sql
EXEC @sql
END
END
ELSE
BEGIN
--PRINT 'got here'
DECLARE csr_TestCaseIdentifierInsert CURSOR FOR
SELECT [TestSequence],[ColumnName],[ColumnValue],[IsAlphaNumeric]
FROM @TestCaseIdentifiers
ORDER BY [TestSequence]
OPEN csr_TestCaseIdentifierInsert
FETCH NEXT FROM csr_TestCaseIdentifierInsert INTO @TestSequence, @ColumnName, @ColumnValue, @IsAlphaNumeric
WHILE @@fetch_status = 0
BEGIN
INSERT INTO [dbo].[TestCasesIdentifier]
([TestCaseId],
[TestCaseSequence],
[FieldName],
[FieldValue],
[AlphaNumeric])
VALUES
(@TestCaseID, @TestSequence, @ColumnName, @ColumnValue,@IsAlphaNumeric)
FETCH NEXT FROM csr_TestCaseIdentifierInsert INTO @TestSequence, @ColumnName, @ColumnValue, @IsAlphaNumeric
END
CLOSE csr_TestCaseIdentifierInsert
DEALLOCATE csr_TestCaseIdentifierInsert
END -- loop to add records to testcasesidentifier
END
END
COMMIT
END TRY
BEGIN CATCH
IF @@TRANCOUNT > 0
ROLLBACK TRAN
DECLARE @ErrorMessage NVARCHAR(4000) = ERROR_MESSAGE()
DECLARE @ErrorSeverity INT = ERROR_SEVERITY()
DECLARE @ErrorState INT = ERROR_STATE()
-- Use RAISERROR inside the CATCH block to return error
-- information about the original error that caused
-- execution to jump to the CATCH block.
RAISERROR (@ErrorMessage, @ErrorSeverity, @ErrorState);
END CATCH
你快到了。我通常也将存储的过程代码包装在 BEGIN..END 块中，接下来是最重要的部分：您必须在 TRY..CATCH 和 BEGIN TRAN 之前添加 SET XACT_ABORT ON;，因为 SQL 服务器默认 XACT_ABORT 为 OFF。否则，并非所有内容都会回滚。
示例设置：
CREATE PROCEDURE dbo.uspMyTestProc
AS
BEGIN
SET NOCOUNT, XACT_ABORT ON;
BEGIN TRY
BEGIN TRANSACTION;
-- Do your magic stuff here before committing...
COMMIT;
END TRY
BEGIN CATCH
IF @@trancount > 0
ROLLBACK TRANSACTION;
-- Add extra error logging here if you want...
END CATCH;
END;
GO
此外，如果您想在使用嵌套过程等时添加可能的堆栈跟踪，您可能需要考虑使用通用错误处理程序 à la Erland Sommerskog。我们完全采用了这种方法。详情见
我在 SQL 服务器中创建了一个存储过程（如下所示）并尝试包含一个回滚事务，因为我需要一个 "stored procedure that has a transaction around it, so that if/when it fails all inserts will be rolled back."
我不确定这是否有效，或者是否会有效，我还不能测试，因为我只是在本地开发，但想知道是否有人不介意查看存储过程的回滚事务部分，并建议是否在正确的道路？
USE AutomatedTesting
GO
ALTER PROCEDURE [dbo].[spInsertTestCases]
(@AddedTFS INT,
@Scenario NVARCHAR(500),
@TargetTableName NVARCHAR(100),
@TargetFieldName NVARCHAR(100),
@ExpectedResult NVARCHAR(100),
@TargetTableDBName NVARCHAR(100),
@TargetTableSchema NVARCHAR(100),
@TargetFieldIsDateTime NVARCHAR(1),
@TestCaseIdentifiers dbo.TestCaseIdentifiers READONLY ) -- can only be READONLY. meaning you cannot amend the param
/* @TestCaseIdentifiers var will be prepopulated
TestDataIdentifiersNEW is a custom data type which has fields (TestSequence ColumnName ColumnValue IsAlphaNumeric)
so stored procedure is called like:
EXEC [dbo].[spTest_UserDefinedDatatype] 'param1','param2' @temp_testdata
@temp_testdata will already be defined and popualted(INSERT INTO ) before exec to add in 1 to many rows.
for example:
ColumnName ColumnValue
PATIENTID 123456
SOURCESYS PAS
in simple terms above EXEC is:
EXEC [dbo].[spTest_UserDefinedDatatype] 'param1','param2' 'PATIENTID 123456'
'SOURCESYS PAS'
*/
AS
BEGIN TRY
BEGIN TRANSACTION
BEGIN
--DECLARE @TableNameUpdate SYSNAME = @TargetTableName
--DECLARE @CDI SYSNAME = REPLACE(@TargetTableName,'CDO','CDI') -- so if targettablename param is CDO then swap it to CDI. why?
DECLARE @sql VARCHAR(MAX) = ' INSERT INTO [dbo].[TestCasesIdentifier] ([TestCaseId], [TestCaseSequence], [FieldName], [FieldValue], [AlphaNumeric]) VALUES '
DECLARE @i INT = 1
DECLARE @TableNameUpdate SYSNAME = @TargetTableName
DECLARE @CDI SYSNAME = REPLACE(@TargetTableName,'CDO','CDI')
DECLARE @ColName SYSNAME
DECLARE @Ret NVARCHAR(256)
DECLARE @sql2 NVARCHAR(MAX)
DECLARE @TestCaseID INT = -1 --does this need default variable?
DECLARE @ErrorCode INT = @@error
DECLARE @TestSequence INT
DECLARE @ColumnName VARCHAR(100)
DECLARE @ColumnValue VARCHAR(100)
DECLARE @IsAlphaNumeric BIT
DECLARE @TableTestSequence INT = ISNULL((SELECT MAX([TableTestSequence]) + 1 FROM TestCases WHERE @TargetTableName = [TargetTableName]), 1)
-- INSERT into TestCases. 1 record
-- An assumption that a number of fields will have defaults on them - if not, extra fields will need adding
INSERT INTO [dbo].[TestCases] ([AddedTFS], [TableTestSequence], [Scenario],
[TargetTableName], [TargetFieldName], [ExpectedResult],
[TargetTableDBName], [TargetTableSchema], [TargetFieldIsDateTime])
VALUES (@AddedTFS, -- AddedTFS (The TFS Number of the Development carried out)
ISNULL((SELECT MAX([TableTestSequence]) + 1 -- TableTestSequence (Generates the next Sequence Number for a Table)
FROM TestCases -- if table doesnt exist in TestCases then sets to 1
WHERE @TargetTableName = [TargetTableName]), 1),
@Scenario, -- Scenario (A description of the scenario use GIVEN and WHERE)
@TargetTableName, -- TargetTableName (References the Target Table entered at the top of this SQL - SET @TableName = 'CDO_APC_ELECTIVE_ADMISSION_LIST')
@TargetFieldName, -- TargetFieldName (The Field in which we want to test)
@ExpectedResult, -- ExpectedResult (The expected output/result of the field in which we want to test)
@TargetTableDBName, -- The DB to be used
@TargetTableSchema, -- the schema to be used
@TargetFieldIsDateTime) ---- 1 = Yes, 0 = No (Is Target field a datetime field)
-- Grab the identity value just generated by the last statement and the last error code generated
-- in order to reference TestCases PK when adding to TestCaseIdentifiers
SELECT @TestCaseID = SCOPE_IDENTITY(), @ErrorCode = @@error
IF @ErrorCode = 0 --OR @TestCaseID <> -1 -- @ErrorCode <> 0 if error then back out testcases INSERT? surely should use BEGIN/ROLLBACK tran
--IF @ErrorCode = 0 OR @TestCaseID <> -1
-- If there was no error creating the TestCase record, create the records for the WHERE clause
BEGIN
/*
rollback insert if no matching records
rollback insert if SQL returns more than 1 record
return error message to user
*/
SELECT
ic.index_column_id, c.name
INTO #tmp
FROM sys.indexes i
JOIN sys.index_columns ic ON i.object_id = ic.object_id
AND i.index_id = ic.index_id
JOIN sys.columns c ON c.column_id = ic.column_id
AND c.object_id = ic.object_id
JOIN sys.tables t ON c.object_id = t.object_id
WHERE t.name = @CDI
AND i.is_primary_key = 1
IF (SELECT COUNT(*) FROM @TestCaseIdentifiers) = 0
--IF @PKValues IS NULL
BEGIN
WHILE @i <= (SELECT COUNT(*) FROM #tmp)
BEGIN
SELECT @ColName = [name]
FROM #tmp
WHERE index_column_id = @i
-- if @expectedvalue IS NULL
SET @sql2 = 'SELECT TOP 1 @RetvalOut = ' + QUOTENAME(@ColName) + ' FROM ' + QUOTENAME(@CDI) + ' ORDER BY NEWID()'
-- else
-- SET @sql2 = ''
EXECUTE sp_executesql @command = @sql2, @ParmDefinition = N'@RetvalOut NVARCHAR(MAX) OUTPUT', @retvalOut = @Ret OUTPUT
SET @sql += '(' + CONVERT(VARCHAR(100),@TestCaseID) + ',' + CONVERT(VARCHAR(10),@i) + ',''' + @ColName + ''',''' + @Ret + ''',1),'
SET @i+=1
SELECT @sql = REVERSE(SUBSTRING(REVERSE(@sql),2,8000))
PRINT @sql
EXEC @sql
END
END
ELSE
BEGIN
--PRINT 'got here'
DECLARE csr_TestCaseIdentifierInsert CURSOR FOR
SELECT [TestSequence],[ColumnName],[ColumnValue],[IsAlphaNumeric]
FROM @TestCaseIdentifiers
ORDER BY [TestSequence]
OPEN csr_TestCaseIdentifierInsert
FETCH NEXT FROM csr_TestCaseIdentifierInsert INTO @TestSequence, @ColumnName, @ColumnValue, @IsAlphaNumeric
WHILE @@fetch_status = 0
BEGIN
INSERT INTO [dbo].[TestCasesIdentifier]
([TestCaseId],
[TestCaseSequence],
[FieldName],
[FieldValue],
[AlphaNumeric])
VALUES
(@TestCaseID, @TestSequence, @ColumnName, @ColumnValue,@IsAlphaNumeric)
FETCH NEXT FROM csr_TestCaseIdentifierInsert INTO @TestSequence, @ColumnName, @ColumnValue, @IsAlphaNumeric
END
CLOSE csr_TestCaseIdentifierInsert
DEALLOCATE csr_TestCaseIdentifierInsert
END -- loop to add records to testcasesidentifier
END
END
COMMIT
END TRY
BEGIN CATCH
IF @@TRANCOUNT > 0
ROLLBACK TRAN
DECLARE @ErrorMessage NVARCHAR(4000) = ERROR_MESSAGE()
DECLARE @ErrorSeverity INT = ERROR_SEVERITY()
DECLARE @ErrorState INT = ERROR_STATE()
-- Use RAISERROR inside the CATCH block to return error
-- information about the original error that caused
-- execution to jump to the CATCH block.
RAISERROR (@ErrorMessage, @ErrorSeverity, @ErrorState);
END CATCH
你快到了。我通常也将存储的过程代码包装在 BEGIN..END 块中，接下来是最重要的部分：您必须在 TRY..CATCH 和 BEGIN TRAN 之前添加 SET XACT_ABORT ON;，因为 SQL 服务器默认 XACT_ABORT 为 OFF。否则，并非所有内容都会回滚。
示例设置：
CREATE PROCEDURE dbo.uspMyTestProc
AS
BEGIN
SET NOCOUNT, XACT_ABORT ON;
BEGIN TRY
BEGIN TRANSACTION;
-- Do your magic stuff here before committing...
COMMIT;
END TRY
BEGIN CATCH
IF @@trancount > 0
ROLLBACK TRANSACTION;
-- Add extra error logging here if you want...
END CATCH;
END;
GO
此外，如果您想在使用嵌套过程等时添加可能的堆栈跟踪，您可能需要考虑使用通用错误处理程序 à la Erland Sommerskog。我们完全采用了这种方法。详情见