当两个表单同时提交时onform提交脚本出错

Question

我有一个 google sheet 脚本，当表单提交时它会做一些事情然后创建一个新的 sheet 最后发送 sheet 作为电子邮件附件.它工作正常但是当两个表单同时提交时（当第二个表单在触发完成之前提交时）电子邮件未发送并且根本不起作用

这是我的代码：

function onSubmit(e){
Logger.log('submit ran');

var ss = SpreadsheetApp.getActiveSpreadsheet();
var sheet = ss.getActiveSheet();


var calculate = ss.getSheets()[2];
var Responses = ss.getSheets()[0];
var report = ss.getSheets()[1];
var report1= ss.getSheets()[3];


var lastRow = Responses.getLastRow();
var copyrange = SpreadsheetApp.CopyPasteType.PASTE_FORMULA, false);
  SpreadsheetApp.flush();

var maxRow1 = report1.getMaxRows();
var lastRow1 = report1.getLastRow();
SpreadsheetApp.flush();
report1.deleteRows(9+count, (172-(9+count)))
SpreadsheetApp.flush();



var email = sB;
var subject = "راید ریپورت "+sa;
var body = se;

var calculate = ss.getSheets()[2];
var Responses = ss.getSheets()[0];
var report = ss.getSheets()[1];


var newSheetid = SpreadsheetApp.create("promoter report "+si,30,60).getId();
var newSheet= DriveApp.getFileById(newSheetid);
DriveApp.getFolderById("1glwG1---------------tW").addFile(newSheet)
newSheet.getParents().next().removeFile(newSheet); 
var sheet = source.getSheets()[3];

var destination = SpreadsheetApp.openById(newSheetid);
sheet.copyTo(destination);


var source = SpreadsheetApp.getActiveSpreadsheet();
var  sheet1= destination.getSheetByName("Sheet1").hideSheet();
var sheet1id=sheet1.getSheetId();

SpreadsheetApp.flush();

var pdf = newSheet.getAs('application/pdf')


MailApp.sendEmail(email,subject ,body, {attachments:[pdf]});
var sf = Responses.getRange(lastRow, 6).setValue("EMAIL_SENT")
SpreadsheetApp.flush();

}

Answer 1

如您所见，您的代码可能运行与模拟表单提交发生冲突

为什么？

因为您对电子表格服务执行多次调用，这会显着降低您的代码速度，您可以在 Best Practices 下阅读。

怎么办？

除了根据 Apps 脚本最佳实践优化代码外，您还可以使用 LockService
Lockservice 允许您确保在给定时间只有一次脚本实例运行和后续调用 "wait in the queue" 直到第一个脚本执行完成

如何使用锁定服务？

基于您的代码的示例：

function onSubmit(e){
  var lock = LockService.getScriptLock();
  // Wait for up to 30 seconds for other processes to finish.
  lock.waitLock(30000);
  Logger.log('submit ran');

  var ss = SpreadsheetApp.getActiveSpreadsheet();
  var sheet = ss.getActiveSheet();


  var calculate = ss.getSheets()[2];
  var Responses = ss.getSheets()[0];
  var report = ss.getSheets()[1];
  var report1= ss.getSheets()[3];


  var lastRow = Responses.getLastRow();
  var copyrange = Responses.getRange("e2:m2").copyTo(Responses.getRange(lastRow, 5), SpreadsheetApp.CopyPasteType.PASTE_FORMULA, false);
  SpreadsheetApp.flush();


  var sh = Responses.getRange(lastRow, 8).getValue();



  var cell = calculate.getRange("c2");
  cell.setFormula(sh);
  SpreadsheetApp.flush();

  SpreadsheetApp.flush();
  var lastRow = Responses.getLastRow();
  var copyrange = Responses.getRange(lastRow, 5,1, 10).copyTo(Responses.getRange(lastRow, 5),SpreadsheetApp.CopyPasteType.PASTE_VALUES, false);

  SpreadsheetApp.flush();
  var sa = Responses.getRange(lastRow, 1).getValue();
  var sB = Responses.getRange(lastRow, 2).getValue();
  var se = Responses.getRange(lastRow, 5).getValue();
  var sf = Responses.getRange(lastRow, 6).getValue();
  var si = Responses.getRange(lastRow, 9).getValue();

  SpreadsheetApp.flush();

  var ss = SpreadsheetApp.getActiveSpreadsheet();

  var rangclear= report1.getRange("a9:z100");
  rangclear.deleteCells(SpreadsheetApp.Dimension.ROWS);

  var count= calculate.getRange("b6").getValue();

  report.getRange("A:Z").copyTo(report1.getRange("A1"));
  SpreadsheetApp.flush();
  report.getRange("A:Z").copyTo(report1.getRange("A1"), SpreadsheetApp.CopyPasteType.PASTE_VALUES, false);
  SpreadsheetApp.flush();

  var maxRow1 = report1.getMaxRows();
  var lastRow1 = report1.getLastRow();
  SpreadsheetApp.flush();
  report1.deleteRows(9+count, (172-(9+count)))
  SpreadsheetApp.flush();

  var email = sB;
  var subject = "راید ریپورت "+sa;
  var body = se;

  var calculate = ss.getSheets()[2];
  var Responses = ss.getSheets()[0];
  var report = ss.getSheets()[1];


  var newSheetid = SpreadsheetApp.create("promoter report "+si,30,60).getId();
  var newSheet= DriveApp.getFileById(newSheetid);
  DriveApp.getFolderById("1glwG1WF2rgrg54hfh0nJjxgtW").addFile(newSheet)
  newSheet.getParents().next().removeFile(newSheet);

  var source = SpreadsheetApp.getActiveSpreadsheet();
  var sheet = source.getSheets()[3];

  var destination = SpreadsheetApp.openById(newSheetid);
  sheet.copyTo(destination);


  var source = SpreadsheetApp.getActiveSpreadsheet();
  var  sheet1= destination.getSheetByName("Sheet1").hideSheet();
  var sheet1id=sheet1.getSheetId();

  SpreadsheetApp.flush();

  var pdf = newSheet.getAs('application/pdf')


  MailApp.sendEmail(email,subject ,body, {attachments:[pdf]});
  var sf = Responses.getRange(lastRow, 6).setValue("EMAIL_SENT")
  SpreadsheetApp.flush();

  // Release the lock so that other processes can continue.
  lock.releaseLock();
}

注：此代码可以进一步优化运行更快

当两个表单同时提交时onform提交脚本出错

error in onform submit script when two form submit at same time

google-apps-script

google-sheets

triggers

google-forms

为什么？

怎么办？

如何使用锁定服务？