我的检查算法不会停止冒泡排序
My check algorithm doesn't stop bubble sort
我有一个包含 25 个震级值的文件。我检查过我的冒泡排序算法管理了 19 或 20 个循环。我的检查方法不停止算法,它写了 24 循环需要。我不明白,我做错了什么。 It is zip file, where you can find data folder and nov20quakedatasmall.atom fid to test
import java.util.*;
import edu.duke.*;
public class QuakeSortInPlace {
public boolean checkInSortedOrder (ArrayList<QuakeEntry> quakes) {
boolean stat = true;
for (int i = 0; i< quakes.size()-1; i++) {
double fParametr = quakes.get(i).getMagnitude();
double sParametr = quakes.get(i+1).getMagnitude();
if (fParametr < sParametr) {
stat = true;
}
else {
stat = false;
break;
}
}
return stat;
}
public void onePassBubbleSort (ArrayList <QuakeEntry> quakeData, int numSorted) {
int loops = 0;
//boolean isSorted = true;
for (int i = 0; i<numSorted; i++) {
//isSorted = true;
for (int k = 0; k<quakeData.size()-i-1; k++) {
double firstCompElement = quakeData.get(k).getMagnitude();
double secondCompElement = quakeData.get(k+1).getMagnitude();
if (firstCompElement > secondCompElement) {
QuakeEntry first = quakeData.get(k);
QuakeEntry second = quakeData.get(k+1);
quakeData.set(k+1 ,first);
quakeData.set(k,second);
// isSorted = false;
}
}
loops++;
if (checkInSortedOrder(quakeData)) {
break;
}
// if (isSorted) {
// break;
// }
}
System.out.print("We needed: "+loops);
}
public void sortByMagnitudeWithBubbleSortWithCheck (ArrayList<QuakeEntry> in) {
int numOfElements = in.size();
int finalNumOfElements = numOfElements-1;
onePassBubbleSort (in, finalNumOfElements);
}
public void testSort() {
EarthQuakeParser parser = new EarthQuakeParser();
String source = "data/nov20quakedatasmall.atom";
ArrayList<QuakeEntry> list = parser.read(source);
System.out.println("read data for "+list.size()+" quakes");
sortByMagnitudeWithBubbleSortWithCheck(list);
for (QuakeEntry qe: list) {
System.out.println(qe);
}
}
}
您的源文件中有两个条目具有相同的值。这会触发 if-statement 中的“else”并导致程序继续下一个循环。
if (fParametr < sParametr) {
stat = true;
}
else {
stat = false;
break;
}
将 (fParametr < sParametr)
更改为 (fParametr <= sParametr)
应该可以解决问题。
我有一个包含 25 个震级值的文件。我检查过我的冒泡排序算法管理了 19 或 20 个循环。我的检查方法不停止算法,它写了 24 循环需要。我不明白,我做错了什么。 It is zip file, where you can find data folder and nov20quakedatasmall.atom fid to test
import java.util.*;
import edu.duke.*;
public class QuakeSortInPlace {
public boolean checkInSortedOrder (ArrayList<QuakeEntry> quakes) {
boolean stat = true;
for (int i = 0; i< quakes.size()-1; i++) {
double fParametr = quakes.get(i).getMagnitude();
double sParametr = quakes.get(i+1).getMagnitude();
if (fParametr < sParametr) {
stat = true;
}
else {
stat = false;
break;
}
}
return stat;
}
public void onePassBubbleSort (ArrayList <QuakeEntry> quakeData, int numSorted) {
int loops = 0;
//boolean isSorted = true;
for (int i = 0; i<numSorted; i++) {
//isSorted = true;
for (int k = 0; k<quakeData.size()-i-1; k++) {
double firstCompElement = quakeData.get(k).getMagnitude();
double secondCompElement = quakeData.get(k+1).getMagnitude();
if (firstCompElement > secondCompElement) {
QuakeEntry first = quakeData.get(k);
QuakeEntry second = quakeData.get(k+1);
quakeData.set(k+1 ,first);
quakeData.set(k,second);
// isSorted = false;
}
}
loops++;
if (checkInSortedOrder(quakeData)) {
break;
}
// if (isSorted) {
// break;
// }
}
System.out.print("We needed: "+loops);
}
public void sortByMagnitudeWithBubbleSortWithCheck (ArrayList<QuakeEntry> in) {
int numOfElements = in.size();
int finalNumOfElements = numOfElements-1;
onePassBubbleSort (in, finalNumOfElements);
}
public void testSort() {
EarthQuakeParser parser = new EarthQuakeParser();
String source = "data/nov20quakedatasmall.atom";
ArrayList<QuakeEntry> list = parser.read(source);
System.out.println("read data for "+list.size()+" quakes");
sortByMagnitudeWithBubbleSortWithCheck(list);
for (QuakeEntry qe: list) {
System.out.println(qe);
}
}
}
您的源文件中有两个条目具有相同的值。这会触发 if-statement 中的“else”并导致程序继续下一个循环。
if (fParametr < sParametr) {
stat = true;
}
else {
stat = false;
break;
}
将 (fParametr < sParametr)
更改为 (fParametr <= sParametr)
应该可以解决问题。