为 DeleteView class 编写的额外函数不起作用
The extra function written for the DeleteView class does not work
我添加了一个功能,如果post被用户删除,如果有上传的照片也会被删除,但是这个功能不起作用
我的看法:
class NewsDeleteView(LoginRequiredMixin, UserPassesTestMixin, DeleteView):
model = News
template_name = 'news/news_delete.html'
success_url = reverse_lazy('news_list')
def delete_header_image(self, pk):
news = get_object_or_404(News, id = pk)
header_image = news.header_image
if header_image is not None:
os.remove(str(header_image))
return HttpResponseRedirect(reverse('news_list'))
else:
return HttpResponseRedirect(reverse('news_list'))
def test_func(self):
obj = self.get_object()
if self.request.user.has_perm('news.all') or self.request.user.has_perm('news.delete_news') or obj.author == self.request.user:
return True
网址:
urlpatterns = [
path('<int:pk>/delete', NewsDeleteView.as_view(), name='news_delete'),
]
型号:
def get_header_image_filepath(self, filepath):
return f'images/news/header/{self.author.id}/{self.header_image}'
class News(models.Model):
title = models.CharField(max_length=255)
header_image = models.ImageField(null=True, blank=True, upload_to=get_header_image_filepath)
body = RichTextUploadingField()
datetime = models.DateTimeField(auto_now_add=True)
author = models.ForeignKey(
AUTH_USER_MODEL,
on_delete=models.CASCADE,
)
def __str__(self):
return self.title
def get_absolute_url(self):
return reverse("news_detail", args=[str(self.id)])
基于 Class 的视图并不神奇。他们已经编写了一些方法,调用这些方法来执行操作。因此,您编写方法 delete_header_image
并不意味着它将被自动调用。相反,您应该覆盖将在内部调用的 class 的一些合适的方法。对于 DeleteView
,执行删除的方法是 delete
,因此您应该覆盖它。此外,条件 if header_image is not None
将不起作用,因为即使没有文件,它也不会由 None
表示,您应该简单地写 if header_image
进行检查。此外,无需手动删除,只需调用 ieldFile.delete
[Django Docs]:
class NewsDeleteView(LoginRequiredMixin, UserPassesTestMixin, DeleteView):
model = News
template_name = 'news/news_delete.html'
success_url = reverse_lazy('news_list')
def delete(self, request, *args, **kwargs):
object = self.get_object()
if object.header_image:
object.header_image.delete(save=False)
return super().delete(request, *args, **kwargs)
def test_func(self):
obj = self.get_object()
if self.request.user.has_perm('news.all') or self.request.user.has_perm('news.delete_news') or obj.author == self.request.user:
return True
我添加了一个功能,如果post被用户删除,如果有上传的照片也会被删除,但是这个功能不起作用
我的看法:
class NewsDeleteView(LoginRequiredMixin, UserPassesTestMixin, DeleteView):
model = News
template_name = 'news/news_delete.html'
success_url = reverse_lazy('news_list')
def delete_header_image(self, pk):
news = get_object_or_404(News, id = pk)
header_image = news.header_image
if header_image is not None:
os.remove(str(header_image))
return HttpResponseRedirect(reverse('news_list'))
else:
return HttpResponseRedirect(reverse('news_list'))
def test_func(self):
obj = self.get_object()
if self.request.user.has_perm('news.all') or self.request.user.has_perm('news.delete_news') or obj.author == self.request.user:
return True
网址:
urlpatterns = [
path('<int:pk>/delete', NewsDeleteView.as_view(), name='news_delete'),
]
型号:
def get_header_image_filepath(self, filepath):
return f'images/news/header/{self.author.id}/{self.header_image}'
class News(models.Model):
title = models.CharField(max_length=255)
header_image = models.ImageField(null=True, blank=True, upload_to=get_header_image_filepath)
body = RichTextUploadingField()
datetime = models.DateTimeField(auto_now_add=True)
author = models.ForeignKey(
AUTH_USER_MODEL,
on_delete=models.CASCADE,
)
def __str__(self):
return self.title
def get_absolute_url(self):
return reverse("news_detail", args=[str(self.id)])
Class 的视图并不神奇。他们已经编写了一些方法,调用这些方法来执行操作。因此,您编写方法 delete_header_image
并不意味着它将被自动调用。相反,您应该覆盖将在内部调用的 class 的一些合适的方法。对于 DeleteView
,执行删除的方法是 delete
,因此您应该覆盖它。此外,条件 if header_image is not None
将不起作用,因为即使没有文件,它也不会由 None
表示,您应该简单地写 if header_image
进行检查。此外,无需手动删除,只需调用 ieldFile.delete
[Django Docs]:
class NewsDeleteView(LoginRequiredMixin, UserPassesTestMixin, DeleteView):
model = News
template_name = 'news/news_delete.html'
success_url = reverse_lazy('news_list')
def delete(self, request, *args, **kwargs):
object = self.get_object()
if object.header_image:
object.header_image.delete(save=False)
return super().delete(request, *args, **kwargs)
def test_func(self):
obj = self.get_object()
if self.request.user.has_perm('news.all') or self.request.user.has_perm('news.delete_news') or obj.author == self.request.user:
return True