/YYYY/MM/Title-Slug URL 结构与 Friendly_Id 解决方案在 #new 和 #edit 上扼流圈

/YYYY/MM/Title-Slug URL structure with Friendly_Id Solution Chokes on #new and #edit

我对我的 有一个部分解决方案,它正确显示 posts#index 和 posts#show 路线,但在创建 post:

ActionController::UrlGenerationError in PostsController#create
No route matches {:action=>"show", :controller=>"posts"} missing required keys: [:id, :month, :year]

Extracted source (around line #32):
30    respond_to do |format|
31      if @post.save
32        format.html { redirect_to post_path, notice: 'Post was successfully created.' }
33        format.json { render :show, status: :created, location: @post }
34      else
35        format.html { render :new }

…并编辑 post:

No route matches [PATCH] "/blog/example-post/blog/2015/09/example-post"

以下是所有有问题的文件(使用同一个非常简单的脚手架博客):

$ rails new blog
[...]
$ cd blog
# (Add friendly_id to Gemfile & install)
$ rails generate friendly_id
$ rails generate scaffold post title content slug:string:uniq
[...]
$ rake db:migrate

routes.rb

Rails.application.routes.draw do
  scope 'blog' do
    get     '',                   to: 'posts#index',  as: 'posts'
    post    '',                   to: 'posts#create'
    get     '/new',               to: 'posts#new',    as: 'new_post'
    get     '/:id/edit',          to: 'posts#edit',   as: 'edit_post'
    get     '/:year/:month/:id',  to: 'posts#show',   as: 'post'
    patch   '/:id',               to: 'posts#update'
    put     '/:id',               to: 'posts#update'
    delete  '/:year/:month/:id',  to: 'posts#destroy'
  end
end

post.rb

class Post < ActiveRecord::Base
  extend FriendlyId
  friendly_id :title, use: :slugged

  def year
    created_at.localtime.strftime("%Y")
  end

  def month
    created_at.localtime.strftime("%m")
  end
end

posts_controller.rb

class PostsController < ApplicationController
  before_action :set_post, only: [:show, :edit, :update, :destroy]

  def index
    @posts = Post.all
  end

  def show
    @post = Post.friendly.find(params[:id])
  end

  def new
    @post = Post.new
  end

  def edit
    @post = Post.friendly.find(params[:id])
  end

  def create
    @post = Post.new(post_params)

    respond_to do |format|
      if @post.save
        format.html { redirect_to post_path, notice: 'Post was successfully created.' }
        format.json { render :show, status: :created, location: @post }
      else
        format.html { render :new }
        format.json { render json: @post.errors, status: :unprocessable_entity }
      end
    end
  end

  def update
    respond_to do |format|
      if @post.update(post_params)
        format.html { redirect_to post_path, notice: 'Post was successfully updated.' }
        format.json { render :show, status: :ok, location: @post }
      else
        format.html { render :edit }
        format.json { render json: @post.errors, status: :unprocessable_entity }
      end
    end
  end

  def destroy
    @post.destroy
    respond_to do |format|
      format.html { redirect_to posts_url, notice: 'Post was successfully destroyed.' }
      format.json { head :no_content }
    end
  end

  private
    # Use callbacks to share common setup or constraints between actions.
    def set_post
      @post = Post.friendly.find(params[:id])
    end

    # Never trust parameters from the scary internet, only allow the white list through.
    def post_params
      params.require(:post).permit(:title, :content, :slug)
    end
  end
end

posts_helper.rb

module PostsHelper

  def post_path(post)
    "blog/#{post.year}/#{post.month}/#{post.slug}"
  end

end

app/views/posts/index.html.erb

<p id="notice"><%= notice %></p>

<h1>Listing Posts</h1>

<table>
  <thead>
    <tr>
      <th>Title</th>
      <th>Content</th>
      <th>Slug</th>
      <th colspan="3"></th>
    </tr>
  </thead>

  <tbody>
  <% @posts.each do |post| %>
    <tr>
      <td><%= post.title %></td>
      <td><%= post.content %></td>
      <td><%= post.slug %></td>
      <td><%= link_to 'Show', post_path(post) %></td>
      <td><%= link_to 'Edit', edit_post_path(post) %></td>
      <td><%= link_to 'Destroy', post, method: :delete, data: { confirm: 'Are you sure?' } %></td>
    </tr>
  <% end %>
  </tbody>
</table>

<br>

<%= link_to 'New Post', new_post_path %>

总而言之,以下是有效的方法:

…什么不起作用:

我很高兴能走到这一步 - 如果能提供解决这些悬而未决问题的任何指导,我们将不胜感激!

编辑

感谢@brad-werth,post 创建已通过以下更改修复:

posts_controller.rb

def create
  @post = Post.new(post_params)

  respond_to do |format|
    if @post.save
      format.html { redirect_to post_path(@post.year, @post.month, @post), notice: 'Post was successfully created.' }

我还尝试通过以下方式解决 post 编辑问题:

将编辑路径更改为 get '/:year/:month/:id/edit', to: 'posts#edit', as: 'edit_post' 并将以下覆盖添加到 posts_helper.rb 以防止索引页中断:

  def edit_post_path(post)
    "#{post.year}/#{post.month}/#{post.slug}/edit"
  end

现在索引页中的 "edit" link 将转到正确的 URL(/blog/2015/09/example-post/edit - 它曾经转到 /blog/example-post/edit)并成功呈现编辑页面。但这会导致 PATCH 中断(实际上,更新不会进入数据库):

No route matches [PATCH] "/blog/2015/09/example-post/blog/2015/09/example-post"

我认识到这个重复问题可能与此 edit_post_path 覆盖有关,但以下强制正确 PATCH 路由的尝试无效:

  1. 将 PATCH 路由更新为 patch '/:year/:month/:id', to: 'posts#update'
  2. 将更新的 PATCH 路由命名为 as: 'patch' 并将 PATCH 路径覆盖添加到 posts_helper:

    def patch_path(post)
      "#{post.year}/#{post.month}/#{post.slug}"
    end
    
  3. 将覆盖更改为:

    def patch_path(post)
      ""
    end
    
  4. 取消命名并将 PATCH 路由更改为 patch '', to: 'posts#update'

查看 posts_controller,问题似乎不存在,因为重定向不是问题所在 - 我不明白为什么 @post.update(post_params) 会出现问题:

  def update
    respond_to do |format|
      if @post.update(post_params)
        format.html { redirect_to @post, notice: 'Post was successfully updated.' }
        format.json { render :show, status: :ok, location: @post }
      else
        format.html { render :edit }
        format.json { render json: @post.errors, status: :unprocessable_entity }
      end
    end
  end

据我所知,URL 中的重复发生在 PATCH 操作之前,这将我们带回了 EDIT 流程 - 它必须将重复传递给 PATCH 并在那里结束窒息。想法?

您的错误状态:

No route matches {:action=>"show", :controller=>"posts"} missing required keys: [:id, :month, :year]

正如您从失败的行 format.html { redirect_to post_path, notice: 'Post was successfully created.' } 中看到的那样,您正在调用 post_path 时不带任何参数。

您的路线 get '/:year/:month/:id', to: 'posts#show', as: 'post' 需要年、月和 ID。这与您上面的错误消息一致。

要修复,只需提供缺少的参数,如下所示:

format.html { redirect_to post_path(@post.year, @post.month, @post), notice: 'Post was successfully created.' }

在更新和创建操作中更改:

format.html { redirect_to post_path, notice: 'Post was successfully ...' }

format.html { redirect_to @post, notice: 'Post was successfully ...' }